From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E666AC31E5B for ; Tue, 18 Jun 2019 18:09:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C6A6C2063F for ; Tue, 18 Jun 2019 18:09:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730266AbfFRSJd convert rfc822-to-8bit (ORCPT ); Tue, 18 Jun 2019 14:09:33 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:35409 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727616AbfFRSJd (ORCPT ); Tue, 18 Jun 2019 14:09:33 -0400 Received: by mail-qt1-f194.google.com with SMTP id d23so16552012qto.2; Tue, 18 Jun 2019 11:09:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=oHj24vcv49o6J15KAKRxHCuXIYgSsjgYc3eEZOnK3fk=; b=tQcQ69As5SqfD/1vGLzwiRL0F6PFGXWQQhGNNct46AHQt+KVM4kJkJe9eCC8QKDCSI 86ODxEiBpgThBMlpUbbX8a8HYRsNSR1QbarY89ZSs32miIK6arxCWhSLtfVK+NUj4Q93 z9z6BEOECw3ApM4+nO5WJgtZ3Y2g7u3wNQJ4aQdJMz7XxUysPfq5iwr3XgeGW0lmWJhm Az5ti351J51onEikochzvgCFq7rnOEMSeGPkyCNl5jCbsUfRn25rGq7k+iUWmxCiE1MW Zzrjkjmzn0QZvoJySk2SyyXK1BgLoxuVsA9lkbKJ3LiOe+3FMMjByU12ZIZ9ud9gcH63 VRsQ== X-Gm-Message-State: APjAAAWagJJy7Ek3waF9Wx6tlMnxlC9K4DeXk53jLHC/0r2tIBc/Kqpt M/TFq0eBSxOvi888M5U6P1nukXOGws8Jl/3NJwg= X-Google-Smtp-Source: APXvYqzoeNQ+qNXk+Bqr/BBsWwStrS4xCx8wxHWRCYgGKPvM4hp6VttYyVgzD05adAZxSxyf/ZDZB37DLa0Eb9Zc8Eg= X-Received: by 2002:aed:2bc1:: with SMTP id e59mr81171140qtd.7.1560881371987; Tue, 18 Jun 2019 11:09:31 -0700 (PDT) MIME-Version: 1.0 References: <20190304204019.2142770-1-arnd@arndb.de> <20190308160441.ler2hs44oaozoq7w@salvia> In-Reply-To: From: Arnd Bergmann Date: Tue, 18 Jun 2019 20:09:15 +0200 Message-ID: Subject: Re: [PATCH] netfilter: nf_conntrack_sip: fix IPV6 dependency To: =?UTF-8?B?QWxpbiBOxINzdGFj?= Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , =?UTF-8?B?TcOhdMOpIEVja2w=?= , Fernando Fernandez Mancera , netfilter-devel , coreteam@netfilter.org, Networking , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Mar 8, 2019 at 5:23 PM Alin Năstac wrote: > On Fri, Mar 8, 2019 at 5:04 PM Pablo Neira Ayuso wrote: > > On Mon, Mar 04, 2019 at 09:40:12PM +0100, Arnd Bergmann wrote: > > > With CONFIG_IPV6=m and CONFIG_NF_CONNTRACK_SIP=y, we now get a link failure: > > > > > > net/netfilter/nf_conntrack_sip.o: In function `process_sdp': > > > nf_conntrack_sip.c:(.text+0x4344): undefined reference to `ip6_route_output_flags' > > > > I see. We can probably use nf_route() instead. > > > > Or if needed, use struct nf_ipv6_ops for this. > > > > if (v6ops) > > ret = v6ops->route_xyz(...); > > > > @Alin: Would you send us a patch to do so to fix a3419ce3356cf1f > > netfilter: nf_conntrack_sip: add sip_external_media logic". > > nf_ip6_route(net, &dst, &fl6, false) seems to be appropriate. > I'll send the patch Monday. I see the original bug I reported is still there. Can you send that patch you had planned to do? Arnd