Netdev Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] netfilter: nf_conntrack_sip: fix IPV6 dependency
@ 2019-03-04 20:40 Arnd Bergmann
  2019-03-08 16:04 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2019-03-04 20:40 UTC (permalink / raw)
  To: Pablo Neira Ayuso, Jozsef Kadlecsik, Florian Westphal, David S. Miller
  Cc: Arnd Bergmann, Máté Eckl, Fernando Fernandez Mancera,
	netfilter-devel, coreteam, netdev, linux-kernel

With CONFIG_IPV6=m and CONFIG_NF_CONNTRACK_SIP=y, we now get a link failure:

net/netfilter/nf_conntrack_sip.o: In function `process_sdp':
nf_conntrack_sip.c:(.text+0x4344): undefined reference to `ip6_route_output_flags'

Fix this by adding a dependency that forces CONFIG_NF_CONNTRACK_SIP to be =m
when CONFIG_IPV6=m, as we already do for several other drivers with a similar
requirement.

Fixes: a3419ce3356c ("netfilter: nf_conntrack_sip: add sip_external_media logic")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 net/netfilter/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
index d43ffb09939b..964bc317ad0a 100644
--- a/net/netfilter/Kconfig
+++ b/net/netfilter/Kconfig
@@ -333,6 +333,7 @@ config NF_CONNTRACK_SANE
 
 config NF_CONNTRACK_SIP
 	tristate "SIP protocol support"
+	depends on IPV6 || IPV6=n
 	default m if NETFILTER_ADVANCED=n
 	help
 	  SIP is an application-layer control protocol that can establish,
-- 
2.20.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] netfilter: nf_conntrack_sip: fix IPV6 dependency
  2019-03-04 20:40 [PATCH] netfilter: nf_conntrack_sip: fix IPV6 dependency Arnd Bergmann
@ 2019-03-08 16:04 ` Pablo Neira Ayuso
  2019-03-08 16:21   ` Alin Năstac
  0 siblings, 1 reply; 5+ messages in thread
From: Pablo Neira Ayuso @ 2019-03-08 16:04 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Jozsef Kadlecsik, Florian Westphal, David S. Miller,
	Máté Eckl, Fernando Fernandez Mancera, netfilter-devel,
	coreteam, netdev, linux-kernel, alin.nastac

hi Arnd,

Cc'ing Alin Nastac.

On Mon, Mar 04, 2019 at 09:40:12PM +0100, Arnd Bergmann wrote:
> With CONFIG_IPV6=m and CONFIG_NF_CONNTRACK_SIP=y, we now get a link failure:
> 
> net/netfilter/nf_conntrack_sip.o: In function `process_sdp':
> nf_conntrack_sip.c:(.text+0x4344): undefined reference to `ip6_route_output_flags'

I see. We can probably use nf_route() instead.

Or if needed, use struct nf_ipv6_ops for this.

        if (v6ops)
                ret = v6ops->route_xyz(...);

@Alin: Would you send us a patch to do so to fix a3419ce3356cf1f
netfilter: nf_conntrack_sip: add sip_external_media logic".

This direct dependency with IPv6 is superfluous, it should not happen.

Thanks!

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] netfilter: nf_conntrack_sip: fix IPV6 dependency
  2019-03-08 16:04 ` Pablo Neira Ayuso
@ 2019-03-08 16:21   ` Alin Năstac
  2019-06-18 18:09     ` Arnd Bergmann
  0 siblings, 1 reply; 5+ messages in thread
From: Alin Năstac @ 2019-03-08 16:21 UTC (permalink / raw)
  To: Pablo Neira Ayuso
  Cc: Arnd Bergmann, Jozsef Kadlecsik, Florian Westphal,
	David S. Miller, Máté Eckl, Fernando Fernandez Mancera,
	netfilter-devel, coreteam, netdev, linux-kernel

Hi Pablo,
On Fri, Mar 8, 2019 at 5:04 PM Pablo Neira Ayuso <pablo@netfilter.org> wrote:
>
> hi Arnd,
>
> Cc'ing Alin Nastac.
>
> On Mon, Mar 04, 2019 at 09:40:12PM +0100, Arnd Bergmann wrote:
> > With CONFIG_IPV6=m and CONFIG_NF_CONNTRACK_SIP=y, we now get a link failure:
> >
> > net/netfilter/nf_conntrack_sip.o: In function `process_sdp':
> > nf_conntrack_sip.c:(.text+0x4344): undefined reference to `ip6_route_output_flags'
>
> I see. We can probably use nf_route() instead.
>
> Or if needed, use struct nf_ipv6_ops for this.
>
>         if (v6ops)
>                 ret = v6ops->route_xyz(...);
>
> @Alin: Would you send us a patch to do so to fix a3419ce3356cf1f
> netfilter: nf_conntrack_sip: add sip_external_media logic".

nf_ip6_route(net, &dst, &fl6, false) seems to be appropriate.
I'll send the patch Monday.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] netfilter: nf_conntrack_sip: fix IPV6 dependency
  2019-03-08 16:21   ` Alin Năstac
@ 2019-06-18 18:09     ` Arnd Bergmann
  2019-06-18 18:13       ` Arnd Bergmann
  0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2019-06-18 18:09 UTC (permalink / raw)
  To: Alin Năstac
  Cc: Pablo Neira Ayuso, Jozsef Kadlecsik, Florian Westphal,
	David S. Miller, Máté Eckl, Fernando Fernandez Mancera,
	netfilter-devel, coreteam, Networking, Linux Kernel Mailing List

On Fri, Mar 8, 2019 at 5:23 PM Alin Năstac <alin.nastac@gmail.com> wrote:

> On Fri, Mar 8, 2019 at 5:04 PM Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > On Mon, Mar 04, 2019 at 09:40:12PM +0100, Arnd Bergmann wrote:
> > > With CONFIG_IPV6=m and CONFIG_NF_CONNTRACK_SIP=y, we now get a link failure:
> > >
> > > net/netfilter/nf_conntrack_sip.o: In function `process_sdp':
> > > nf_conntrack_sip.c:(.text+0x4344): undefined reference to `ip6_route_output_flags'
> >
> > I see. We can probably use nf_route() instead.
> >
> > Or if needed, use struct nf_ipv6_ops for this.
> >
> >         if (v6ops)
> >                 ret = v6ops->route_xyz(...);
> >
> > @Alin: Would you send us a patch to do so to fix a3419ce3356cf1f
> > netfilter: nf_conntrack_sip: add sip_external_media logic".
>
> nf_ip6_route(net, &dst, &fl6, false) seems to be appropriate.
> I'll send the patch Monday.

I see the original bug I reported is still there. Can you send that patch
you had planned to do?

       Arnd

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] netfilter: nf_conntrack_sip: fix IPV6 dependency
  2019-06-18 18:09     ` Arnd Bergmann
@ 2019-06-18 18:13       ` Arnd Bergmann
  0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2019-06-18 18:13 UTC (permalink / raw)
  To: Alin Năstac
  Cc: Pablo Neira Ayuso, Jozsef Kadlecsik, Florian Westphal,
	David S. Miller, Máté Eckl, Fernando Fernandez Mancera,
	netfilter-devel, coreteam, Networking, Linux Kernel Mailing List

On Tue, Jun 18, 2019 at 8:09 PM Arnd Bergmann <arnd@arndb.de> wrote:
> On Fri, Mar 8, 2019 at 5:23 PM Alin Năstac <alin.nastac@gmail.com> wrote:
> > On Fri, Mar 8, 2019 at 5:04 PM Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > > On Mon, Mar 04, 2019 at 09:40:12PM +0100, Arnd Bergmann wrote:
> > > > With CONFIG_IPV6=m and CONFIG_NF_CONNTRACK_SIP=y, we now get a link failure:
> > > >
> > > > net/netfilter/nf_conntrack_sip.o: In function `process_sdp':
> > > > nf_conntrack_sip.c:(.text+0x4344): undefined reference to `ip6_route_output_flags'
> > >
> > > I see. We can probably use nf_route() instead.
> > >
> > > Or if needed, use struct nf_ipv6_ops for this.
> > >
> > >         if (v6ops)
> > >                 ret = v6ops->route_xyz(...);
> > >
> > > @Alin: Would you send us a patch to do so to fix a3419ce3356cf1f
> > > netfilter: nf_conntrack_sip: add sip_external_media logic".
> >
> > nf_ip6_route(net, &dst, &fl6, false) seems to be appropriate.
> > I'll send the patch Monday.
>
> I see the original bug I reported is still there. Can you send that patch
> you had planned to do?

Hmm, I think I mixed up this patch with a different one that is missing.
Please ignore my reply above.

      Arnd

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-04 20:40 [PATCH] netfilter: nf_conntrack_sip: fix IPV6 dependency Arnd Bergmann
2019-03-08 16:04 ` Pablo Neira Ayuso
2019-03-08 16:21   ` Alin Năstac
2019-06-18 18:09     ` Arnd Bergmann
2019-06-18 18:13       ` Arnd Bergmann

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org netdev@archiver.kernel.org
	public-inbox-index netdev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox