From: Arnd Bergmann <arnd@kernel.org>
To: Richard Cochran <richardcochran@gmail.com>
Cc: 王擎 <wangqing@vivo.com>, "Jakub Kicinski" <kuba@kernel.org>,
"Grygorii Strashko" <grygorii.strashko@ti.com>,
"David S. Miller" <davem@davemloft.net>,
"Samuel Zou" <zou_wei@huawei.com>,
"Kurt Kanzenbach" <kurt@linutronix.de>,
"Ivan Khoronzhuk" <ivan.khoronzhuk@linaro.org>,
Networking <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR
Date: Fri, 13 Nov 2020 17:21:43 +0100 [thread overview]
Message-ID: <CAK8P3a3V98x3s7DvHtutiz97Q=5QjfS6Xn4kH2r2iamY3dzwkw@mail.gmail.com> (raw)
In-Reply-To: <20201112232735.GA26605@hoboy.vegasvil.org>
On Fri, Nov 13, 2020 at 12:27 AM Richard Cochran
<richardcochran@gmail.com> wrote:
>
> On Thu, Nov 12, 2020 at 10:21:21PM +0100, Arnd Bergmann wrote:
> > I agree that the 'imply' keyword in Kconfig is what made this a
> > lot worse, and it would be best to replace that with normal
> > dependencies.
>
> IIRC, this all started with tinification and wanting dynamic posix
> clocks to be optional at compile time.
>
> I would like to simplify this whole mess:
>
> - restore dynamic posix clocks to be always included
>
> - make PHC always included when the MAC has that feature (by saying
> "select" in the MAC Kconfig) -- I think this is what davem had
> wanted back in the day ...
>
> I'm not against tinification in principle, but I believe it is a lost
> cause.
My preference would be to avoid both 'select' and 'imply' here,
both of them cause their own set of problems. The main downside
of 'select' is that you can't mix it with 'depends on' without risking
running into circular dependencies and impossible configurations,
while the main problem with 'imply' is that the behavior is close to
unpredictable. The original definition still made some sense to me,
but the new definition of 'imply' seems completely meaningless.
I've prototyped a patch that I think makes this more sensible
again: https://pastebin.com/AQ5nWS9e
This needs testing, but if you think the approach makes sense,
I can give it a few randconfig builds and submit for wider review.
Arnd
next prev parent reply other threads:[~2020-11-13 16:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 9:24 [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR Wang Qing
2020-11-11 12:32 ` Richard Cochran
2020-11-11 13:24 ` Grygorii Strashko
2020-11-11 13:55 ` Richard Cochran
2020-11-11 16:00 ` Jakub Kicinski
2020-11-12 1:15 ` 王擎
2020-11-12 1:32 ` Jakub Kicinski
2020-11-12 2:48 ` 王擎
2020-11-12 4:23 ` Jakub Kicinski
2020-11-12 8:25 ` Arnd Bergmann
2020-11-12 10:05 ` Grygorii Strashko
2020-11-12 18:14 ` Richard Cochran
2020-11-12 18:19 ` Richard Cochran
2020-11-12 21:21 ` Arnd Bergmann
2020-11-12 23:27 ` Richard Cochran
2020-11-13 16:21 ` Arnd Bergmann [this message]
2020-11-14 15:14 ` Richard Cochran
2020-11-14 21:16 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a3V98x3s7DvHtutiz97Q=5QjfS6Xn4kH2r2iamY3dzwkw@mail.gmail.com' \
--to=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=grygorii.strashko@ti.com \
--cc=ivan.khoronzhuk@linaro.org \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=wangqing@vivo.com \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).