From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8B5BC4338F for ; Mon, 2 Aug 2021 14:37:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B22BD60F58 for ; Mon, 2 Aug 2021 14:37:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234229AbhHBOiA (ORCPT ); Mon, 2 Aug 2021 10:38:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:44878 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233925AbhHBOh7 (ORCPT ); Mon, 2 Aug 2021 10:37:59 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A7EA760F5A; Mon, 2 Aug 2021 14:37:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627915069; bh=rjcQFbefs4y8JgCbUFdJmgVkXkThVhcwqF9WjgoJ+Qo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=AGjDHM9zoZPQcQ1/pFuwYYKiW7tWnt6cXUBqqRX0DQIFsMIpy4MS+2E2mSMbcyH0/ uGVd3PF/DEkXYoTs03fpVZDpKfCNCYYIOMS1IeaAObHxH1X0CrcGnfnESnWkDLuE7D fGKsdmEmw72k9cxtW3bGaUp1GoUes1itvEl0D/G6SdjUO5rKNFVEBald3rv2D7obxw EcMGlTFylFkv3c1lL2I8B+7jMqkQspRafaG37PmQBq/pm5pxzxQRWaWjMmGRCzdvyU oz3ogpGHtKb8Yrnsq7fmJCqWcDUgblaStB+jFYjNMPlU1yQu5jL/cyTIbIniUO4fP0 QYWK9wbWArvmQ== Received: by mail-wm1-f48.google.com with SMTP id l34-20020a05600c1d22b02902573c214807so8509980wms.2; Mon, 02 Aug 2021 07:37:49 -0700 (PDT) X-Gm-Message-State: AOAM533wkjgxel0mit8wO03GeCVGIv7lSwXY04S+cErTWR/8IBunu1w8 VIVGjQVu17DCbGTxWEYxghpvJMthuSpDyp+/MYM= X-Google-Smtp-Source: ABdhPJz2CjiBj+grqC6TsAgL3UXrYpUYw974570svL7N/F/FFAMi39HARl7wlXhmOQD3aMN8wkEdOY4DSpgmMaDTJJ8= X-Received: by 2002:a05:600c:3641:: with SMTP id y1mr8196846wmq.43.1627915068330; Mon, 02 Aug 2021 07:37:48 -0700 (PDT) MIME-Version: 1.0 References: <20210726084540.3282344-1-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Mon, 2 Aug 2021 16:37:32 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [Intel-wired-lan] [PATCH] ethernet/intel: fix PTP_1588_CLOCK dependencies To: "G, GurucharanX" Cc: "Brandeburg, Jesse" , "Nguyen, Anthony L" , "David S. Miller" , Jakub Kicinski , "Keller, Jacob E" , "intel-wired-lan@lists.osuosl.org" , Arnd Bergmann , "netdev@vger.kernel.org" , Kurt Kanzenbach , "linux-kernel@vger.kernel.org" , "Saleem, Shiraz" , "intel-wired-lan-bounces@osuosl.org" , Richard Cochran Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Aug 2, 2021 at 3:10 PM G, GurucharanX wrote: > > > > From: Arnd Bergmann > > > > The 'imply' keyword does not do what most people think it does, it only > > politely asks Kconfig to turn on another symbol, but does not prevent it from > > being disabled manually or built as a loadable module when the user is built- > > in. In the ICE driver, the latter now causes a link failure: ... > Tested-by: Gurucharan G (A Contingent Worker at Intel) Sorry for the delay. I had remembered that there was a previous discussion about that option but couldn't find the thread at first. I now found https://lore.kernel.org/netdev/CAK8P3a3=eOxE-K25754+fB_-i_0BZzf9a9RfPTX3ppSwu9WZXw@mail.gmail.com/ and will add Richard to Cc for my new version as well, just in case he has objections to this version and wants to fix it differently. Arnd