From: Arnd Bergmann <arnd@kernel.org>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Martin Sebor <msebor@gcc.gnu.org>, Tejun Heo <tj@kernel.org>,
Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
"the arch/x86 maintainers" <x86@kernel.org>,
Ning Sun <ning.sun@intel.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Kalle Valo <kvalo@codeaurora.org>,
Simon Kelley <simon@thekelleys.org.uk>,
James Smart <james.smart@broadcom.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Anders Larsen <al@alarsen.net>, Serge Hallyn <serge@hallyn.com>,
Imre Deak <imre.deak@intel.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
tboot-devel@lists.sourceforge.net,
Intel Graphics <intel-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
ath11k@lists.infradead.org,
linux-wireless <linux-wireless@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>,
LSM List <linux-security-module@vger.kernel.org>,
Roman Gushchin <guro@fb.com>,
Christian Brauner <christian.brauner@ubuntu.com>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andriin@fb.com>, Odin Ugedal <odin@uged.al>,
Cong Wang <xiyou.wangcong@gmail.com>,
Bhaskar Chowdhury <unixbhaskar@gmail.com>
Subject: Re: [PATCH 06/11] cgroup: fix -Wzero-length-bounds warnings
Date: Tue, 30 Mar 2021 11:00:36 +0200 [thread overview]
Message-ID: <CAK8P3a3nUCGwPpE+E820DniY8Haz1Xx72pA38P6s5MWsbi0iAQ@mail.gmail.com> (raw)
In-Reply-To: <YGLkPjSBdgpriC0E@blackbook>
On Tue, Mar 30, 2021 at 10:41 AM Michal Koutný <mkoutny@suse.com> wrote:
>
> On Mon, Mar 22, 2021 at 05:02:44PM +0100, Arnd Bergmann <arnd@kernel.org> wrote:
> > I'm not sure what is expected to happen for such a configuration,
> > presumably these functions are never calls in that case.
> Yes, the functions you patched would only be called from subsystems or
> there should be no way to obtain a struct cgroup_subsys reference
> anyway (hence it's ok to always branch as if ss==NULL).
>
> I'd prefer a variant that wouldn't compile the affected codepaths when
> there are no subsystems registered, however, I couldn't come up with a
> way how to do it without some preprocessor ugliness.
Would it be possible to enclose most or all of kernel/cgroup/cgroup.c
in an #ifdef CGROUP_SUBSYS_COUNT block? I didn't try that
myself, but this might be a way to guarantee that there cannot
be any callers (it would cause a link error).
> Reviewed-by: Michal Koutný <mkoutny@suse.com>
Thanks
Arnd
next prev parent reply other threads:[~2021-03-30 9:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 16:02 [PATCH 00/11] treewide: address gcc-11 -Wstringop-overread warnings Arnd Bergmann
2021-03-22 16:02 ` [PATCH 01/11] x86: compressed: avoid gcc-11 -Wstringop-overread warning Arnd Bergmann
2021-03-22 16:02 ` [PATCH 02/11] x86: tboot: avoid Wstringop-overread-warning Arnd Bergmann
2021-03-22 20:29 ` Ingo Molnar
2021-03-22 21:39 ` Arnd Bergmann
2021-03-22 22:07 ` Martin Sebor
2021-03-22 22:49 ` Arnd Bergmann
2021-03-22 23:13 ` Ingo Molnar
2021-03-24 9:11 ` David Laight
2021-03-24 10:39 ` David Laight
2021-03-22 16:02 ` [PATCH 03/11] security: commoncap: fix -Wstringop-overread warning Arnd Bergmann
2021-03-22 16:31 ` Christian Brauner
2021-03-24 20:50 ` James Morris
2021-03-22 16:02 ` [PATCH 04/11] ath11: Wstringop-overread warning Arnd Bergmann
2021-09-28 9:04 ` Kalle Valo
2021-03-22 16:02 ` [PATCH 05/11] qnx: avoid -Wstringop-overread warning Arnd Bergmann
2021-03-22 16:02 ` [PATCH 06/11] cgroup: fix -Wzero-length-bounds warnings Arnd Bergmann
2021-03-30 8:41 ` Michal Koutný
2021-03-30 9:00 ` Arnd Bergmann [this message]
2021-03-30 14:44 ` Michal Koutný
2021-03-22 16:02 ` [PATCH 07/11] ARM: sharpsl_param: work around -Wstringop-overread warning Arnd Bergmann
2021-03-22 16:02 ` [PATCH 08/11] atmel: avoid gcc -Wstringop-overflow warning Arnd Bergmann
2021-03-22 16:02 ` [PATCH 09/11] scsi: lpfc: fix gcc -Wstringop-overread warning Arnd Bergmann
2021-03-22 16:02 ` [PATCH 10/11] drm/i915: avoid stringop-overread warning on pri_latency Arnd Bergmann
2021-03-24 15:30 ` Jani Nikula
2021-03-24 17:22 ` Ville Syrjälä
2021-03-22 16:02 ` [PATCH 11/11] [RFC] drm/i915/dp: fix array overflow warning Arnd Bergmann
2021-03-25 8:05 ` Jani Nikula
2021-03-25 9:53 ` Arnd Bergmann
2021-03-25 14:49 ` Martin Sebor
2021-03-30 10:56 ` Hans de Goede
2021-04-06 4:53 ` [PATCH 00/11] treewide: address gcc-11 -Wstringop-overread warnings Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a3nUCGwPpE+E820DniY8Haz1Xx72pA38P6s5MWsbi0iAQ@mail.gmail.com \
--to=arnd@kernel.org \
--cc=al@alarsen.net \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=cgroups@vger.kernel.org \
--cc=christian.brauner@ubuntu.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=james.smart@broadcom.com \
--cc=jani.nikula@linux.intel.com \
--cc=jejb@linux.ibm.com \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=mkoutny@suse.com \
--cc=msebor@gcc.gnu.org \
--cc=netdev@vger.kernel.org \
--cc=ning.sun@intel.com \
--cc=odin@uged.al \
--cc=serge@hallyn.com \
--cc=simon@thekelleys.org.uk \
--cc=tboot-devel@lists.sourceforge.net \
--cc=tj@kernel.org \
--cc=unixbhaskar@gmail.com \
--cc=x86@kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).