From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_MED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48D07C282CE for ; Wed, 5 Jun 2019 02:25:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F45A20828 for ; Wed, 5 Jun 2019 02:25:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ultpNBTa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726605AbfFECZ1 (ORCPT ); Tue, 4 Jun 2019 22:25:27 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:40080 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726354AbfFECZ1 (ORCPT ); Tue, 4 Jun 2019 22:25:27 -0400 Received: by mail-wm1-f68.google.com with SMTP id v19so618959wmj.5 for ; Tue, 04 Jun 2019 19:25:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SnYR6UZNsIvvezN/6trGEygcm/uVduKyboqjmbEpP9c=; b=ultpNBTaJe8wTr2RMZjxbkkAHpcs+N5Qbak1KbsiqMtl4gzjHFdM3RVb14kGvH+zCx st1ppCYB+VD6eAs+XHKXu1AIi+vV3eA7VcK0JpV1vV0t9NgsTniggY2oVAB7umjlQeS0 7Kdq7zVpVq3adlId/zIcr+ga3ASd20C7cUSOvwjJFbJ/HFnyWneTxd5cub/0zBTxbJ/Z 0jDM345kodlVKkwBHp59Po/AEBE5Nons9o974ASL2Y+4ZxvOhT1Zkcpv5dLitG7oiAFk n0WuzYguAYR/B8nNHHOxs9J3f22s0va9mhcFGMClWs4TNGpISboO/E9fVhDVaB8og4R3 TB9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SnYR6UZNsIvvezN/6trGEygcm/uVduKyboqjmbEpP9c=; b=eKBifxVCSO4JprW8383342lhADc8EpRtaQMw1q+z3EvwThbK+r8NVlpNwM7yrMQ2By L8RWWwNRCU634cAxwuxAW1tTwdKjKf2BqPiv6m4bI7skAcrXielmI8lF4gsNmcb/uA/N BsmCWDdTVvl5YYPasTTGvKrubTla75rOcAN+enTEY0CVusBbwwDeTjceHjJCVWaFDgpu UIwqVtuJR8LUCaC4zOFUilMUcrTPNo7ogoAiIAZdZkskP1tPXjDxvrcTGsMYgX+wENq4 YimStQC/1Xtrj0VKOtk0Ukux15Eh/szbDXkeD1jPPW17tP5ZBUVynomZkXjfaqALOi7O Ds4A== X-Gm-Message-State: APjAAAUpJ9SlftulSwkC/qYNsjUQSd1TSqsBDLWldkxqd3ZPmO6SQbrb 1+DyW+YU/oE2kYq2gpiq/Y6w4rFa4yh3Um7I4/M+aA== X-Google-Smtp-Source: APXvYqzrkj4SrglYfwm2m8irSGKyjWgmAMoRYHzLGbNogklt6ZQGQnKoULwjcAA8pSaU4VYQO16wXtOgifHiJhRHdR4= X-Received: by 2002:a7b:c444:: with SMTP id l4mr8285341wmi.15.1559701524983; Tue, 04 Jun 2019 19:25:24 -0700 (PDT) MIME-Version: 1.0 References: <20190507091118.24324-1-liuhangbin@gmail.com> <20190508.093541.1274244477886053907.davem@davemloft.net> <20190605014344.GY18865@dhcp-12-139.nay.redhat.com> <20190605021533.GZ18865@dhcp-12-139.nay.redhat.com> In-Reply-To: <20190605021533.GZ18865@dhcp-12-139.nay.redhat.com> From: Lorenzo Colitti Date: Wed, 5 Jun 2019 11:25:11 +0900 Message-ID: Subject: Re: [PATCH net] fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied To: Hangbin Liu Cc: David Ahern , David Miller , Yaro Slav , Thomas Haller , Alistair Strachan , Greg KH , Linux NetDev , David Ahern , =?UTF-8?Q?Maciej_=C5=BBenczykowski?= Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jun 5, 2019 at 11:15 AM Hangbin Liu wrote: > How do you add the rules? with ip cmd it should has NLM_F_EXCL flag and > you will get -EEXIST error out. The fact that the code worked before this commit implies that it was *not* using NLM_F_EXCL. :-) The code is here if you want to take a look. https://android.googlesource.com/platform/system/netd/+/master/server/RouteController.cpp#576 https://android.googlesource.com/platform/system/netd/+/master/server/NetlinkCommands.h#33