From: Stanislav Fomichev <sdf@google.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Fangrui Song <maskray@google.com>,
Stanislav Fomichev <sdf@fomichev.me>, bpf <bpf@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Nathan Chancellor <natechancellor@gmail.com>,
clang-built-linux <clang-built-linux@googlegroups.com>,
"David S. Miller" <davem@davemloft.net>,
Alexei Starovoitov <ast@kernel.org>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH bpf-next v5] bpf: Support llvm-objcopy and llvm-objdump for vmlinux BTF
Date: Tue, 17 Mar 2020 15:12:56 -0700 [thread overview]
Message-ID: <CAKH8qBteBDQp_Jw2RhM5u6x2q75+PtRwX6jZZQggjpeohWQEzg@mail.gmail.com> (raw)
In-Reply-To: <CAKwvOd=gaX1CBTirziwK8MxQuERTqH65xMBHNzRXHR4uOTY4bw@mail.gmail.com>
On Tue, Mar 17, 2020 at 3:08 PM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> On Tue, Mar 17, 2020 at 3:01 PM Fangrui Song <maskray@google.com> wrote:
> >
> > On 2020-03-17, Stanislav Fomichev wrote:
> > >Please keep small changelog here, for example:
> > >
> > >v5:
> > >* rebased on top of bpfnext
> >
> > Thanks for the tip. Add them at the bottom?
>
> "Below the fold" see this patch I just sent out:
> https://lore.kernel.org/lkml/20200317215515.226917-1-ndesaulniers@google.com/T/#u
> grep "Changes"
>
> $ git format-patch -v2 HEAD~
> $ vim 0001-...patch
> <manually add changelog "below the fold">
BPF subtree prefers the changelog in the commit body, not the comments
(iow, before ---).
Add them at the end of you message, see, for example:
https://lore.kernel.org/bpf/a428fb88-9b53-27dd-a195-497755944921@iogearbox.net/T/
> --
> Thanks,
> ~Nick Desaulniers
next prev parent reply other threads:[~2020-03-17 22:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 21:16 [PATCH bpf-next v5] bpf: Support llvm-objcopy and llvm-objdump for vmlinux BTF Fangrui Song
2020-03-17 21:51 ` Stanislav Fomichev
2020-03-17 22:01 ` Fangrui Song
2020-03-17 22:08 ` Nick Desaulniers
2020-03-17 22:12 ` Stanislav Fomichev [this message]
2020-03-17 23:14 ` Nick Desaulniers
2020-03-17 23:44 ` Daniel Borkmann
2020-03-17 21:55 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKH8qBteBDQp_Jw2RhM5u6x2q75+PtRwX6jZZQggjpeohWQEzg@mail.gmail.com \
--to=sdf@google.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=keescook@chromium.org \
--cc=maskray@google.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).