netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kristian Evensen <kristian.evensen@gmail.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] qmi_wwan: Increase headroom for QMAP SKBs
Date: Wed, 6 Jan 2021 16:18:29 +0100	[thread overview]
Message-ID: <CAKfDRXh2WmT=aAU9CZg=AniW=qOQ4XLHVcYHnjvX8f+CguZBsw@mail.gmail.com> (raw)
In-Reply-To: <87ft3e3zo1.fsf@miraculix.mork.no>

Hi Bjørn,

On Wed, Jan 6, 2021 at 3:31 PM Bjørn Mork <bjorn@mork.no> wrote:
> Nice work!

Thanks a lot!

> Just wondering: Will the same problem affect the usbnet allocated skbs
> as well in case of raw-ip? They will obviously be large enough, but the
> reserved headroom probably isn't when we put an IP packet there without
> any L2 header?

You are right, I completely forgot about those SKBs. I will try to
find some time to investigate the non-QMAP performance, if a similar
fix (I guess an skb_reserve after the case-statement is enough) will
have an effect and submit a follow-up patch in case. Thanks for
reminding me, I have switched to only use QMAP :)

BR,
Kristian

  reply	other threads:[~2021-01-06 15:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-06 12:24 [PATCH net-next] qmi_wwan: Increase headroom for QMAP SKBs Kristian Evensen
2021-01-06 14:31 ` Bjørn Mork
2021-01-06 15:18   ` Kristian Evensen [this message]
2021-01-07 20:07   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKfDRXh2WmT=aAU9CZg=AniW=qOQ4XLHVcYHnjvX8f+CguZBsw@mail.gmail.com' \
    --to=kristian.evensen@gmail.com \
    --cc=bjorn@mork.no \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).