From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57406C433EF for ; Sun, 5 Sep 2021 15:53:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F0FC60F51 for ; Sun, 5 Sep 2021 15:53:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237941AbhIEPy2 (ORCPT ); Sun, 5 Sep 2021 11:54:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236545AbhIEPyY (ORCPT ); Sun, 5 Sep 2021 11:54:24 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4044C061575 for ; Sun, 5 Sep 2021 08:53:20 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id e21so8115064ejz.12 for ; Sun, 05 Sep 2021 08:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8/rHObnVcA+CHkGC0ScxYD7AHQulA6jGTXzVzfO0V9c=; b=M4z7ylVOA1TJkPqkMMOtlDKvXL+W3NsOH+5gUtFLcfHEAjY4kTpKmmWLXfhL39hDLq RtPGvb/CMY9yis3oYBf4zCfp2rVNeyTa2fQgUDjWcVP18ZcYJUH5W80M7HwN5plBchea OeOGW7x0TDD1BesYaFSEsCHZd+NoYm2uBfLLSGR7Xbm2vm2LM6e4eSQOuMkI6I/pwnlI UIAxfxEuth25GMaQ5/ojOhShqwnqxS+NBtzgBhg7p2EM4pKa0osKaIiDLwpb0tJ3PdhK NObb4qWJC07Sttwdm5+GHVdjkArjNlFfN98pJwd9yYg76SXIpZNgF7OGdxSbDA3brD4q j2dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8/rHObnVcA+CHkGC0ScxYD7AHQulA6jGTXzVzfO0V9c=; b=GyHeKSj0pr35yd+tDvvsCBk7NKaX8MkPe6bDsc94dgo9oteQQdDZowqBPYL7Gas5fi 13h8Jmtw71YOpkdQN3W1W1ROKxsDFAulNxiNsc1HVumI9Jljod4R0JaRpK3ySMHCh4Dq dHskj3J5KEeu6lHPZ7bGSFUGmziyEiLuZ05hslhznwajn2yNG3I0hO7Rh87NpDnqY0Id zqRsLeCuhTdVmIxItxbExpCj9LWr46UFkGAAPTJbFatcoLVf/vo3vlihRIn9vbPF3D/q QuE1mwqpVel72Sj+4wUjuIY8q4EYC5UVwaKZtJLDCsnhs9vspGJt+2z8ch1Wsewvg+YB 6SXA== X-Gm-Message-State: AOAM532lxmLk+NulA8qfWAm2Y5A19gXczUBo4nqHla8gXqWHYLlmXwWN jEhL/uLHhU8zlzcWqubkMTOLgEF+pm17iK0HpnT4hReo X-Google-Smtp-Source: ABdhPJzbEhhIR6nGbGIXbiOZHNb7YO/xSWYDyU5PbfpTFyohLBhoJFFuWIK1AFidFyADRTVZnEgZpzLgSsejfiKFl6A= X-Received: by 2002:a17:906:3e10:: with SMTP id k16mr9424765eji.116.1630857199155; Sun, 05 Sep 2021 08:53:19 -0700 (PDT) MIME-Version: 1.0 References: <20210902193447.94039-1-willemdebruijn.kernel@gmail.com> <20210902193447.94039-2-willemdebruijn.kernel@gmail.com> In-Reply-To: From: Alexander Duyck Date: Sun, 5 Sep 2021 08:53:08 -0700 Message-ID: Subject: Re: [PATCH net] ip_gre: validate csum_start only if CHECKSUM_PARTIAL To: Willem de Bruijn Cc: Netdev , David Miller , Jakub Kicinski , Ido Schimmel , chouhan.shreyansh630@gmail.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Sep 5, 2021 at 8:24 AM Willem de Bruijn wrote: > > On Sat, Sep 4, 2021 at 7:47 PM Alexander Duyck > wrote: > > You can do it since you have essentially already written half the code.. :) > > Sent, but only the ipv4 patch. > > I actually do not see an equivalent skb_pull path in ip6_gre.c. Will > take a closer look later, but don't have time for that now. > > https://patchwork.kernel.org/project/netdevbpf/patch/20210905152109.1805619-1-willemdebruijn.kernel@gmail.com/ So does that mean that commit 9cf448c200ba ("ip6_gre: add validation for csum_start") is adding overhead that doesn't really address anything, and is introducing false positives? If so, should we just revert it? Thanks, - Alex