From: Nick Desaulniers <ndesaulniers@google.com>
To: Nathan Huckleberry <nhuck@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
maxime.chevallier@bootlin.com, netdev@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH v2] net: mvpp2: debugfs: Add pmap to fs dump
Date: Wed, 19 Jun 2019 13:46:35 -0700 [thread overview]
Message-ID: <CAKwvOdk7xOF8=xv5A7TQUWY29dH4agDWgMJVeO9emTMbH8CNQA@mail.gmail.com> (raw)
In-Reply-To: <20190619181715.253903-1-nhuck@google.com>
On Wed, Jun 19, 2019 at 11:17 AM 'Nathan Huckleberry' via Clang Built
Linux <clang-built-linux@googlegroups.com> wrote:
>
> There was an unused variable 'mvpp2_dbgfs_prs_pmap_fops'
> Added a usage consistent with other fops to dump pmap
> to userspace.
> Changes from v1 -> v2
> * Fix typo
> * Change commit prefix to debugfs
Compile-
Tested-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Requires `make ... W=1` before the patch to observe the warning.
> drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c
> index 0ee39ea47b6b..274fb07362cb 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c
> @@ -566,6 +566,9 @@ static int mvpp2_dbgfs_prs_entry_init(struct dentry *parent,
> debugfs_create_file("hits", 0444, prs_entry_dir, entry,
> &mvpp2_dbgfs_prs_hits_fops);
>
> + debugfs_create_file("pmap", 0444, prs_entry_dir, entry,
> + &mvpp2_dbgfs_prs_pmap_fops);
> +
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2019-06-19 20:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 17:53 Cleanup of -Wunused-const-variable in drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c Nathan Huckleberry
2019-06-18 6:39 ` Maxime Chevallier
2019-06-18 16:09 ` [PATCH] net: mvpp2: cls: Add pmap to fs dump Nathan Huckleberry
2019-06-18 19:00 ` Nick Desaulniers
2019-06-19 2:33 ` David Miller
2019-06-19 6:49 ` Maxime Chevallier
2019-06-19 18:17 ` [PATCH v2] net: mvpp2: debugfs: " Nathan Huckleberry
2019-06-19 20:46 ` Nick Desaulniers [this message]
2019-06-19 21:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOdk7xOF8=xv5A7TQUWY29dH4agDWgMJVeO9emTMbH8CNQA@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=clang-built-linux@googlegroups.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=nhuck@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).