From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83E81C43613 for ; Mon, 24 Jun 2019 17:37:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5217E20645 for ; Mon, 24 Jun 2019 17:37:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="wNEKXNOW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732529AbfFXRh2 (ORCPT ); Mon, 24 Jun 2019 13:37:28 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:42253 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729502AbfFXRh2 (ORCPT ); Mon, 24 Jun 2019 13:37:28 -0400 Received: by mail-pl1-f193.google.com with SMTP id ay6so7270573plb.9 for ; Mon, 24 Jun 2019 10:37:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RwuuIvtxcBljmc7PFWojSi2N+7tyjtOMabnfff7jpmo=; b=wNEKXNOWP5PlYCgptKgZXfJolBfYoJLb1MoczYQas9THpCa1SKApTdEiaM93xCZOaI 6fR/W3O+LArPZ8Z/WwDDGsIFgOmNiwN8s+DW6eHNwCdT8Y5YQDImB3U9OUT/hYJ8w4xx +4/t3TQu0kbcQ9kz4GbtAMc+CYKvmKJXZB62kYI2uaZhkS5rgnufTkHAxbap3eKbLjNe N66ugUnMkY9ARFqXkAxle6zQpnfLDNtGq88tkYBSrUG/4eRV7ypx1n6l03bkeZlWRgi5 rOaJy5hrS4jRer/8YsmvumqcpqB/gcnilGjvkNB75QlxxCrK30CewEFybxMRFmLycIrO hhBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RwuuIvtxcBljmc7PFWojSi2N+7tyjtOMabnfff7jpmo=; b=LSRotEu5mKe2zKReqhyt/EuDd3LY61A2elg9YRiPqQe3j593BOghDjfPCtpYrHqUgk iyqKvYonz5aqCOBMtgfSgUxrwWw00E7aFsgS0/Lxqprtf1OJgatCRUcOWpiNim+/bnp7 4ZVV+2TiTN6vz3hQe4c+O/pA2T8scbtaARDTbNC2tjmeU6IQyapxAjwK8fDXL6YpA8gO kuw0mtAOIUbdEHfcaFhTKIXMk5/7RjmTAPb5fESgJeDK1jVFvtHLFeQKOpks0vEBn1b9 xJGXQ9q4tmpCtTM0sYKVznkVzye7WRtPnOBm2YdoOYAvslnzMndDdOIzlt37eFqWSUid wFPQ== X-Gm-Message-State: APjAAAU+XpyRXTmiUWaJfkebI4cSYDkeoJaBtNQb9UDP8QJaLPmzWQKe YJ4cff+xBVkwAGj0cHx5EBSM919YNB+wP0b3/p+ODRrgwvg= X-Google-Smtp-Source: APXvYqywWCSSedYTgwqIkJyMW8oZCbox9RzzBLyFvc25sU21urptslg5Ui+b5r9UxivbJusrk7t8rPQnHZSGo8fpQg4= X-Received: by 2002:a17:902:b944:: with SMTP id h4mr24520563pls.179.1561397846032; Mon, 24 Jun 2019 10:37:26 -0700 (PDT) MIME-Version: 1.0 References: <20190624.100609.1416082266723674267.davem@davemloft.net> <20190624.102212.4398258272798722.davem@davemloft.net> In-Reply-To: <20190624.102212.4398258272798722.davem@davemloft.net> From: Nick Desaulniers Date: Mon, 24 Jun 2019 10:37:14 -0700 Message-ID: Subject: Re: [PATCH net v2 1/2] ipv6: constify rt6_nexthop() To: David Miller , Nicolas Dichtel Cc: netdev@vger.kernel.org, kbuild test robot Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jun 24, 2019 at 10:22 AM David Miller wrote: > > From: Nick Desaulniers > Date: Mon, 24 Jun 2019 10:17:03 -0700 > > > On Mon, Jun 24, 2019 at 10:06 AM David Miller wrote: > >> And you mean just changing to 'const' fixes something, how? > > > > See the warning in the above link (assuming now you have access). > > Assigning a non-const variable the result of a function call that > > returns const discards the const qualifier. > > Ok thanks for clarifying. > > However I was speaking in terms of this fixing a functional bug rather > than a loss of const warning. The author stated that this patch was no functional change. Nicolas, it can be helpful to include compiler warnings in the commit message when sending warning fixes, but it's not a big deal. Thanks for sending the patches. -- Thanks, ~Nick Desaulniers