From: Nick Desaulniers <ndesaulniers@google.com>
To: Jose Abreu <Jose.Abreu@synopsys.com>
Cc: Network Development <netdev@vger.kernel.org>,
Joao Pinto <Joao.Pinto@synopsys.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
"David S. Miller" <davem@davemloft.net>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
linux-stm32@st-md-mailman.stormreply.com,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH net 8/8] net: stmmac: xgmac: Fix RSS not writing all Keys to HW
Date: Fri, 27 Sep 2019 14:12:23 -0700 [thread overview]
Message-ID: <CAKwvOdntD5HNb4Gg04YN7iZwvK3CB4enq4ZPhUM-Bd3huvR2pw@mail.gmail.com> (raw)
In-Reply-To: <80dd26ecf7fc82c88dc378d78210df5dd4138812.1569569778.git.Jose.Abreu@synopsys.com>
On Fri, Sep 27, 2019 at 12:49 AM Jose Abreu <Jose.Abreu@synopsys.com> wrote:
>
> The sizeof(cfg->key) is != ARRAY_SIZE(cfg->key). Fix it.
I think the warning was from -Wsizeof-array-div.
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Reported-by: Nick Desaulniers <ndesaulniers@google.com>
I may have reported the kbuild link, but scanning my email, there's
also a report from
Reported-by: Nathan Chancellor <natechancellor@gmail.com>
> Fixes: 76067459c686 ("net: stmmac: Implement RSS and enable it in XGMAC core")
> Signed-off-by: Jose Abreu <Jose.Abreu@synopsys.com>
>
> ---
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: Jose Abreu <joabreu@synopsys.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: netdev@vger.kernel.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Nick Desaulniers <ndesaulniers@google.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c
> index 6d8ac2ef4fc2..4a1f52474dbc 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c
> @@ -533,7 +533,7 @@ static int dwxgmac2_rss_configure(struct mac_device_info *hw,
> return 0;
> }
>
> - for (i = 0; i < (sizeof(cfg->key) / sizeof(u32)); i++) {
> + for (i = 0; i < (ARRAY_SIZE(cfg->key) / sizeof(u32)); i++) {
cfg is an instance of struct stmmac_rss, which looks like:
125 struct stmmac_rss {
126 int enable;
127 u8 key[STMMAC_RSS_HASH_KEY_SIZE];
128 u32 table[STMMAC_RSS_MAX_TABLE_SIZE];
129 };
yep, LGTM. Thanks for the patch.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> ret = dwxgmac2_rss_write_reg(ioaddr, true, i, cfg->key[i]);
> if (ret)
> return ret;
> --
> 2.7.4
>
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2019-09-27 21:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 7:48 [PATCH net 0/8] net: stmmac: Fixes for -net Jose Abreu
2019-09-27 7:48 ` [PATCH net 1/8] net: stmmac: xgmac: Not all Unicast addresses may be available Jose Abreu
2019-09-27 7:48 ` [PATCH net 2/8] net: stmmac: xgmac: Detect Hash Table size dinamically Jose Abreu
2019-09-27 7:48 ` [PATCH net 3/8] net: stmmac: selftests: Always use max DMA size in Jumbo Test Jose Abreu
2019-09-27 7:48 ` [PATCH net 4/8] net: stmmac: dwmac4: Always update the MAC Hash Filter Jose Abreu
2019-09-27 7:48 ` [PATCH net 5/8] net: stmmac: Correctly take timestamp for PTPv2 Jose Abreu
2019-09-27 7:48 ` [PATCH net 6/8] net: stmmac: Do not stop PHY if WoL is enabled Jose Abreu
2019-09-27 7:48 ` [PATCH net 7/8] net: stmmac: xgmac: Disable the Timestamp interrupt by default Jose Abreu
2019-09-27 7:48 ` [PATCH net 8/8] net: stmmac: xgmac: Fix RSS not writing all Keys to HW Jose Abreu
2019-09-27 21:12 ` Nick Desaulniers [this message]
2019-09-28 9:01 ` [PATCH net 0/8] net: stmmac: Fixes for -net Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKwvOdntD5HNb4Gg04YN7iZwvK3CB4enq4ZPhUM-Bd3huvR2pw@mail.gmail.com \
--to=ndesaulniers@google.com \
--cc=Joao.Pinto@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=clang-built-linux@googlegroups.com \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).