From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A56EC433F5 for ; Sat, 18 Sep 2021 11:21:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5EBD161244 for ; Sat, 18 Sep 2021 11:21:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239114AbhIRLWq (ORCPT ); Sat, 18 Sep 2021 07:22:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233735AbhIRLWp (ORCPT ); Sat, 18 Sep 2021 07:22:45 -0400 Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D13DC061757 for ; Sat, 18 Sep 2021 04:21:22 -0700 (PDT) Received: by mail-io1-xd2c.google.com with SMTP id f6so15618006iox.0 for ; Sat, 18 Sep 2021 04:21:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ojab.ru; s=ojab; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+vTIBq7OgcFSIUkKEdHY3wi/HPPALeiPsoDimZEmejs=; b=TB7+9svnr9db5eEQUcCbKnnthERxnsR3zGSst85Gue8c5XVSczZl73Z3IQ8pRQfT3c 7ZoKYL6RyebbyeInS8PBtSlIu7ibrCwG32ouDax/Ezk8jYGrxqo3TndHw2eqAwfY13dN 9V/+EThULN+urYK/0fnnBbnraXPIl/T8mbPIDcr6aRMwDh2KRjXt3ir27rUKwA7Wv+9S Y+VefQsIGKFPPmPRfFvFoYNP/CvB6FfBTp7Wv1rZQHFOKnkfhLFpELOwMOuiZye51uWT G5icb2n99Mcu+90RKzfpCg5SU68h27lE/XZhrc0SI9UfiWqxdidObJhBjP32Zgshluca plaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+vTIBq7OgcFSIUkKEdHY3wi/HPPALeiPsoDimZEmejs=; b=ZAMwuaOh2GM61vGo7p/PZfzQzVLjCEWKVtaK6QRP3EO2zrBJtSxEpSyPLb8ftYdsYp SxA8VpB5qFiJFLIhQCML1FzN+DoL9nkC07SYGCqd2WvtsSA9jJiBFnRuckP+KArb2zYK A1UZFJwkPXR8xHneWGWUGXn/vmQroymb2so7xm761agWFBZASpj/QnkfHQWjWSe7gxHh Tk+HRBhrZ9OQGNr48SvJeKw2XONE+TwV9K/ymyG095U/hDHbjeyByI/BolAI9GVtRVd6 YROYJsL1Qpm2vFw1mygmCA3oWg4YO1BJw20k+EEYDEPcaBUoGfRcJyFCL1FQnoeDfRSS hFRQ== X-Gm-Message-State: AOAM532mKCU91Sr90Vbi11sNns0oXnkZtxoeRfW6pDZiCoeKunQCn02Q FmAaDDSqpHiIgCyhojdlVHLo3vaILqtUkxbey54vetoqhUs+zA== X-Google-Smtp-Source: ABdhPJwawAEnPF7WRSLXu4E3brYMb0Nevsg4dHFpW+EkY/D0CNrUQ0zciPKvDG41wbFIpYfBR3EDXX6UubRwmQc25yE= X-Received: by 2002:a6b:f007:: with SMTP id w7mr12181943ioc.112.1631964081521; Sat, 18 Sep 2021 04:21:21 -0700 (PDT) MIME-Version: 1.0 References: <20210722193459.7474-1-ojab@ojab.ru> <538825a2-82f0-6102-01da-6e0385e53cf5@gmx.de> In-Reply-To: <538825a2-82f0-6102-01da-6e0385e53cf5@gmx.de> From: "ojab //" Date: Sat, 18 Sep 2021 14:21:10 +0300 Message-ID: Subject: Re: [PATCH V2] ath10k: don't fail if IRAM write fails To: "sparks71@gmx.de" Cc: Kalle Valo , "David S. Miller" , Jakub Kicinski , ath10k@lists.infradead.org, Linux Wireless , netdev@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org oh, awesome. Thanks! //wbr ojab On Sat, 18 Sept 2021 at 13:12, sparks71@gmx.de wrote: > > Have you seen the new patch? > > https://www.mail-archive.com/ath10k@lists.infradead.org/msg13784.html > > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=973de582639a1e45276e4e3e2f3c2d82a04ad0a6 > > > could probably have been communicated better > > > best regards > > > > Am 17.09.21 um 21:30 schrieb ojab //: > > ._. > > > > //wbr ojab > > > > On Thu, 9 Sept 2021 at 02:42, ojab // wrote: > >> Gentle ping. > >> > >> //wbr ojab > >> > >> On Wed, 25 Aug 2021 at 19:15, ojab // wrote: > >>> Can I haz it merged? > >>> > >>> //wbr ojab > >>> > >>> On Thu, 22 Jul 2021 at 22:36, ojab wrote: > >>>> After reboot with kernel & firmware updates I found `failed to copy > >>>> target iram contents:` in dmesg and missing wlan interfaces for both > >>>> of my QCA9984 compex cards. Rolling back kernel/firmware didn't fixed > >>>> it, so while I have no idea what's actually happening, I don't see why > >>>> we should fail in this case, looks like some optional firmware ability > >>>> that could be skipped. > >>>> > >>>> Also with additional logging there is > >>>> ``` > >>>> [ 6.839858] ath10k_pci 0000:04:00.0: No hardware memory > >>>> [ 6.841205] ath10k_pci 0000:04:00.0: failed to copy target iram contents: -12 > >>>> [ 6.873578] ath10k_pci 0000:07:00.0: No hardware memory > >>>> [ 6.875052] ath10k_pci 0000:07:00.0: failed to copy target iram contents: -12 > >>>> ``` > >>>> so exact branch could be seen. > >>>> > >>>> Signed-off-by: Slava Kardakov > >>>> --- > >>>> Of course I forgot to sing off, since I don't use it by default because I > >>>> hate my real name and kernel requires it > >>>> > >>>> drivers/net/wireless/ath/ath10k/core.c | 9 ++++++--- > >>>> 1 file changed, 6 insertions(+), 3 deletions(-) > >>>> > >>>> diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c > >>>> index 2f9be182fbfb..d9fd5294e142 100644 > >>>> --- a/drivers/net/wireless/ath/ath10k/core.c > >>>> +++ b/drivers/net/wireless/ath/ath10k/core.c > >>>> @@ -2691,8 +2691,10 @@ static int ath10k_core_copy_target_iram(struct ath10k *ar) > >>>> u32 len, remaining_len; > >>>> > >>>> hw_mem = ath10k_coredump_get_mem_layout(ar); > >>>> - if (!hw_mem) > >>>> + if (!hw_mem) { > >>>> + ath10k_warn(ar, "No hardware memory"); > >>>> return -ENOMEM; > >>>> + } > >>>> > >>>> for (i = 0; i < hw_mem->region_table.size; i++) { > >>>> tmp = &hw_mem->region_table.regions[i]; > >>>> @@ -2702,8 +2704,10 @@ static int ath10k_core_copy_target_iram(struct ath10k *ar) > >>>> } > >>>> } > >>>> > >>>> - if (!mem_region) > >>>> + if (!mem_region) { > >>>> + ath10k_warn(ar, "No memory region"); > >>>> return -ENOMEM; > >>>> + } > >>>> > >>>> for (i = 0; i < ar->wmi.num_mem_chunks; i++) { > >>>> if (ar->wmi.mem_chunks[i].req_id == > >>>> @@ -2917,7 +2921,6 @@ int ath10k_core_start(struct ath10k *ar, enum ath10k_firmware_mode mode, > >>>> if (status) { > >>>> ath10k_warn(ar, "failed to copy target iram contents: %d", > >>>> status); > >>>> - goto err_hif_stop; > >>>> } > >>>> } > >>>> > >>>> -- > >>>> 2.32.0 > > _______________________________________________ > > ath10k mailing list > > ath10k@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/ath10k > > > > >