netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Xing <kerneljasonxing@gmail.com>
To: Florian Westphal <fw@strlen.de>
Cc: edumazet@google.com, pablo@netfilter.org, kadlec@netfilter.org,
	 kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net,
	 netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	 netdev@vger.kernel.org, Jason Xing <kernelxing@tencent.com>
Subject: Re: [PATCH nf-next v2] netfilter: conntrack: avoid sending RST to reply out-of-window skb
Date: Wed, 13 Mar 2024 10:24:01 +0800	[thread overview]
Message-ID: <CAL+tcoAyiGcGAb7aqK+jhf1BeSM8BeH1ZTbzvLVxd_vNGmSVUA@mail.gmail.com> (raw)
In-Reply-To: <20240312122417.GA2899@breakpoint.cc>

Hello Florian,

On Tue, Mar 12, 2024 at 8:24 PM Florian Westphal <fw@strlen.de> wrote:
>
> Jason Xing <kerneljasonxing@gmail.com> wrote:
> > I think, even we have set DNAT policy, it would be better if the
> > whole process/behaviour adheres to the original TCP behaviour as
> > default.
>
> LGTM.
> Acked-by: Florian Westphal <fw@strlen.de>

Thanks!

I wonder if I should repost it in two weeks? BTW, what about the
status of the other two patches[1][2]? Should I repost them after
March 25th too?

[1]:  https://lore.kernel.org/netdev/20240308092915.9751-1-kerneljasonxing@gmail.com/
[2]: https://lore.kernel.org/netdev/20240308092915.9751-2-kerneljasonxing@gmail.com/

  reply	other threads:[~2024-03-13  2:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-11  7:05 [PATCH nf-next v2] netfilter: conntrack: avoid sending RST to reply out-of-window skb Jason Xing
2024-03-12 12:24 ` Florian Westphal
2024-03-13  2:24   ` Jason Xing [this message]
2024-03-18 20:16 ` Simon Horman
2024-03-19  2:52   ` Jason Xing
2024-03-19 18:46     ` Simon Horman
2024-03-21 21:06 ` Pablo Neira Ayuso
2024-03-22  1:06   ` Jason Xing
2024-03-22 10:40     ` Pablo Neira Ayuso
2024-03-22 10:50   ` Jozsef Kadlecsik
2024-03-22 11:07     ` Jason Xing
2024-03-22 20:16       ` Jozsef Kadlecsik
2024-03-23  0:25         ` Jason Xing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL+tcoAyiGcGAb7aqK+jhf1BeSM8BeH1ZTbzvLVxd_vNGmSVUA@mail.gmail.com \
    --to=kerneljasonxing@gmail.com \
    --cc=coreteam@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=kadlec@netfilter.org \
    --cc=kernelxing@tencent.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).