From: Roland Dreier <roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>
To: parav.pandit-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/9] ocrdma: Driver for Emulex OneConnect RDMA adapter
Date: Wed, 21 Mar 2012 09:20:00 -0700 [thread overview]
Message-ID: <CAL1RGDVxCE--P78bk0Me5o+ekSzgBYG0UJT6y3O7cK3mUGBjuQ@mail.gmail.com> (raw)
In-Reply-To: <24c5b654-d6a5-418d-8187-fba4ad47a3ce-nbYkmrCdWxmgMrCBcu8zE0EOCMrvLtNR@public.gmane.org>
On Tue, Mar 20, 2012 at 3:39 PM, <parav.pandit-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org> wrote:
> From: Parav Pandit <parav.pandit-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org>
>
> - Header file for userspace library and kernel driver interface.
> +struct ocrdma_alloc_ucontext_resp {
> + u32 dev_id;
> + u32 wqe_size;
> + u32 max_inline_data;
> + u32 dpp_wqe_size;
> + u64 ah_tbl_page;
> + u32 ah_tbl_len;
> + u32 rsvd;
> + u8 fw_ver[32];
> + u32 rqe_size;
> + u64 rsvd1;
> +} __packed;
If I'm reading this correctly, you have the 8-byte rsvd1 member at an
offset only aligned to 4 bytes, because of the __packed directive. It
would be much better to have these structures laid out so they are
naturally the same on both 32-bit and 64-bit ABIs, and get rid of the
__packed directive, which wrecks gcc code generation in some cases.
In this particular case, it seems you could just move rqe_size into the
slot where rsvd is, and get rid of rsvd1?
> +/* user kernel communication data structures. */
> +struct ocrdma_alloc_pd_ureq {
> + u64 rsvd1;
> +} __packed;
Similar comment -- __packed is silly for a structure with one reserved
member (and which you don't seem to use anywhere)... why not just
delete this struct?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next parent reply other threads:[~2012-03-21 16:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1332283154-16369-1-git-send-email-parav.pandit@emulex.com>
[not found] ` <1332283154-16369-2-git-send-email-parav.pandit@emulex.com>
[not found] ` <24c5b654-d6a5-418d-8187-fba4ad47a3ce@exht1.ad.emulex.com>
[not found] ` <24c5b654-d6a5-418d-8187-fba4ad47a3ce-nbYkmrCdWxmgMrCBcu8zE0EOCMrvLtNR@public.gmane.org>
2012-03-21 16:20 ` Roland Dreier [this message]
[not found] ` <CAL1RGDVxCE--P78bk0Me5o+ekSzgBYG0UJT6y3O7cK3mUGBjuQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-21 16:31 ` [PATCH 2/9] ocrdma: Driver for Emulex OneConnect RDMA adapter David Laight
[not found] ` <AE90C24D6B3A694183C094C60CF0A2F6026B6EB4-CgBM+Bx2aUAnGFn1LkZF6NBPR1lH4CV8@public.gmane.org>
2012-03-22 20:52 ` Parav.Pandit-iH1Dq9VlAzfQT0dZR+AlfA
[not found] ` <88B766C272F2C64B944B21AD078333151C964A66EF-/SwythR3zqxVRK6PHKByhFaTQe2KTcn/@public.gmane.org>
2012-03-22 20:58 ` Jason Gunthorpe
[not found] ` <20120322205824.GC9614-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2012-03-22 21:10 ` Parav.Pandit-iH1Dq9VlAzfQT0dZR+AlfA
[not found] ` <88B766C272F2C64B944B21AD078333151C964A670B-/SwythR3zqxVRK6PHKByhFaTQe2KTcn/@public.gmane.org>
2012-03-22 21:20 ` Parav.Pandit-iH1Dq9VlAzfQT0dZR+AlfA
[not found] ` <3ae9829d-f8dd-4268-918a-94616eff0915-nbYkmrCdWxmgMrCBcu8zE0EOCMrvLtNR@public.gmane.org>
2012-03-22 22:44 ` Jason Gunthorpe
[not found] ` <20120322224429.GA12980-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2012-03-22 23:45 ` Roland Dreier
2012-03-23 9:41 ` David Laight
2012-03-23 14:03 ` Parav.Pandit-iH1Dq9VlAzfQT0dZR+AlfA
[not found] ` <88B766C272F2C64B944B21AD078333151C964A67E0-/SwythR3zqxVRK6PHKByhFaTQe2KTcn/@public.gmane.org>
2012-03-23 16:54 ` Jason Gunthorpe
[not found] ` <20120323165414.GA15260-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2012-03-23 19:16 ` Parav.Pandit-iH1Dq9VlAzfQT0dZR+AlfA
2012-03-21 19:02 ` Parav.Pandit-iH1Dq9VlAzfQT0dZR+AlfA
[not found] ` <1332283154-16369-3-git-send-email-parav.pandit@emulex.com>
[not found] ` <339d9e05-38fd-45b1-83ed-f06277bd1326@exht1.ad.emulex.com>
[not found] ` <339d9e05-38fd-45b1-83ed-f06277bd1326-nbYkmrCdWxmgMrCBcu8zE0EOCMrvLtNR@public.gmane.org>
2012-03-21 16:26 ` [PATCH 3/9] " Roland Dreier
[not found] ` <CAL1RGDWnc478=ToFQEC51Usn6LLZgLen=CymFZ0C0GnRp9BAsw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-21 16:33 ` David Laight
2012-03-21 19:04 ` Parav.Pandit-iH1Dq9VlAzfQT0dZR+AlfA
[not found] ` <88B766C272F2C64B944B21AD078333151C964A63F1-/SwythR3zqxVRK6PHKByhFaTQe2KTcn/@public.gmane.org>
2012-03-21 19:33 ` Roland Dreier
[not found] ` <CAL1RGDWmz4Yr8mqWMywN9X+refDEJ4W=ieBvOtZZc32qMDA5_w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-21 20:54 ` Jason Gunthorpe
[not found] ` <1332283154-16369-4-git-send-email-parav.pandit@emulex.com>
[not found] ` <a5e59a7c-d6ff-4c78-89a7-fad7492260b0@exht1.ad.emulex.com>
[not found] ` <a5e59a7c-d6ff-4c78-89a7-fad7492260b0-nbYkmrCdWxmgMrCBcu8zE0EOCMrvLtNR@public.gmane.org>
2012-03-21 16:34 ` [PATCH 4/9] " Roland Dreier
2012-03-21 19:09 ` Parav.Pandit
[not found] ` <88B766C272F2C64B944B21AD078333151C964A63FB-/SwythR3zqxVRK6PHKByhFaTQe2KTcn/@public.gmane.org>
2012-03-21 19:31 ` Roland Dreier
[not found] ` <CAL1RGDWrwP3mY2=W42_c5wpefzqx_BnXhnwfy2fPrP=12hrBOw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-21 19:46 ` Parav.Pandit-iH1Dq9VlAzfQT0dZR+AlfA
[not found] ` <1332283154-16369-5-git-send-email-parav.pandit@emulex.com>
[not found] ` <1332283154-16369-6-git-send-email-parav.pandit@emulex.com>
[not found] ` <5abe3043-81f8-448a-9e55-b29e23f4eb9a@exht1.ad.emulex.com>
[not found] ` <5abe3043-81f8-448a-9e55-b29e23f4eb9a-nbYkmrCdWxmgMrCBcu8zE0EOCMrvLtNR@public.gmane.org>
2012-03-21 16:42 ` [PATCH 6/9] " Roland Dreier
2012-03-21 19:10 ` Parav.Pandit-iH1Dq9VlAzfQT0dZR+AlfA
[not found] ` <3f46a051-ee2e-4e18-becf-60f6c023c3c6@exht1.ad.emulex.com>
[not found] ` <3f46a051-ee2e-4e18-becf-60f6c023c3c6-nbYkmrCdWxmgMrCBcu8zE0EOCMrvLtNR@public.gmane.org>
2012-03-21 16:14 ` [PATCH 1/9] " Roland Dreier
2012-03-21 18:58 ` Parav.Pandit
2012-03-21 16:45 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL1RGDVxCE--P78bk0Me5o+ekSzgBYG0UJT6y3O7cK3mUGBjuQ@mail.gmail.com \
--to=roland-bhel68plqrggvpxpguhicg@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=parav.pandit-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).