From: Jeff Barnhill <0xeffeff@gmail.com>
To: David Ahern <dsahern@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
yoshfuji@linux-ipv6.org
Subject: Re: [PATCH net v4] net/ipv6: Add anycast addresses to a global hashtable
Date: Sat, 27 Oct 2018 21:27:04 -0400 [thread overview]
Message-ID: <CAL6e_peP8_h43maaUGhfyybqmDfAfSOTdrHig0iXEN4DD2gYvQ@mail.gmail.com> (raw)
In-Reply-To: <8b4e657f-f64a-060b-e535-d9a487db64ed@gmail.com>
You are right, David...I mistook the refcount_dec_and_test() in
aca_put() as being for the fib6_info, but it's for the aca_refcnt.
Thanks! I'll submit a corrected patch.
On Sat, Oct 27, 2018 at 7:39 PM David Ahern <dsahern@gmail.com> wrote:
>
> On 10/27/18 12:02 PM, Jeff Barnhill wrote:
> > @@ -275,6 +356,11 @@ int __ipv6_dev_ac_inc(struct inet6_dev *idev, const struct in6_addr *addr)
> > err = -ENOMEM;
> > goto out;
> > }
> > + err = ipv6_add_acaddr_hash(dev_net(idev->dev), addr);
> > + if (err) {
> > + aca_put(aca);
> > + goto out;
> > + }
> >
> > aca->aca_next = idev->ac_list;
> > idev->ac_list = aca;
>
> you misunderstood my comment. aca_put is instead of a double call to
> fib6_info_release(f6i). You still need one call to
> fib6_info_release(f6i) for the addrconf_f6i_alloc.
next prev parent reply other threads:[~2018-10-28 10:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 2:12 [PATCH net] net/ipv6: Add anycast addresses to a global hashtable Jeff Barnhill
2018-10-23 2:26 ` Eric Dumazet
2018-10-23 18:21 ` Jeff Barnhill
2018-10-24 1:58 ` [PATCH net v2] " Jeff Barnhill
2018-10-24 3:12 ` Eric Dumazet
2018-10-24 5:06 ` Jeff Barnhill
2018-10-26 21:22 ` [PATCH net v3] " Jeff Barnhill
2018-10-26 21:44 ` David Ahern
2018-10-27 18:02 ` [PATCH net v4] " Jeff Barnhill
2018-10-27 23:39 ` David Ahern
2018-10-28 1:27 ` Jeff Barnhill [this message]
2018-10-28 1:51 ` [PATCH net v5] " Jeff Barnhill
2018-10-30 3:32 ` David Miller
2018-10-30 11:10 ` Jeff Barnhill
2018-10-30 18:31 ` David Miller
2018-10-30 22:06 ` David Ahern
2018-10-30 23:19 ` David Miller
2018-11-01 0:02 ` Jeff Barnhill
2018-11-01 0:14 ` [PATCH net v6] " Jeff Barnhill
2018-11-01 5:34 ` Stephen Hemminger
2018-11-02 20:23 ` [PATCH net v7] " Jeff Barnhill
2018-11-03 6:55 ` David Miller
2018-11-01 2:53 ` [PATCH net v5] " David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL6e_peP8_h43maaUGhfyybqmDfAfSOTdrHig0iXEN4DD2gYvQ@mail.gmail.com \
--to=0xeffeff@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).