netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: sundeep subbaraya <sundeep.lkml@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org, sgoutham@marvell.com,
	Subbaraya Sundeep <sbhatta@marvell.com>
Subject: Re: [PATCH net 0/3] Fix bugs in Octeontx2 netdev driver
Date: Sat, 25 Jul 2020 10:11:22 +0530	[thread overview]
Message-ID: <CALHRZuq1fqrGfuyoEuXhddeJ_u07mgBnUTmjixkW_2btrtZGHQ@mail.gmail.com> (raw)
In-Reply-To: <20200724.201037.91669607453014965.davem@davemloft.net>

Hi David,

On Sat, Jul 25, 2020 at 8:40 AM David Miller <davem@davemloft.net> wrote:
>
> From: sundeep subbaraya <sundeep.lkml@gmail.com>
> Date: Fri, 24 Jul 2020 08:40:44 +0530
>
> > On Fri, Jul 24, 2020 at 12:43 AM David Miller <davem@davemloft.net> wrote:
> >>
> >> If you leave interrupts on then an interrupt can arrive after the software
> >> state has been released by unregister_netdev.
> >>
> >> Sounds like you need to resolve this some other way.
> >
> > Only mailbox interrupts can arrive after unregister_netdev since
> > otx2_stop disables
> > the packet I/O and its interrupts as the first step.
> > And mbox interrupts are turned off after unregister_neetdev.
> > unregister_netdev(netdev);
> > otx2vf_disable_mbox_intr(vf);
>
> Please explain this in your commit message.
>
> Thank you.
Sure will change the commit message.

Thanks,
Sundeep

      reply	other threads:[~2020-07-25  4:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21 17:14 [PATCH net 0/3] Fix bugs in Octeontx2 netdev driver sundeep.lkml
2020-07-21 17:14 ` [PATCH net 1/3] octeontx2-pf: Fix reset_task bugs sundeep.lkml
2020-07-21 17:14 ` [PATCH net 2/3] octeontx2-pf: cancel reset_task work sundeep.lkml
2020-07-21 17:14 ` [PATCH net 3/3] octeontx2-pf: Unregister netdev at driver remove sundeep.lkml
2020-07-21 23:17 ` [PATCH net 0/3] Fix bugs in Octeontx2 netdev driver David Miller
2020-07-22 14:04   ` sundeep subbaraya
2020-07-23 14:59     ` sundeep subbaraya
2020-07-23 19:13       ` David Miller
2020-07-24  3:10         ` sundeep subbaraya
2020-07-25  3:10           ` David Miller
2020-07-25  4:41             ` sundeep subbaraya [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALHRZuq1fqrGfuyoEuXhddeJ_u07mgBnUTmjixkW_2btrtZGHQ@mail.gmail.com \
    --to=sundeep.lkml@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sbhatta@marvell.com \
    --cc=sgoutham@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).