From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FE7AC43381 for ; Fri, 15 Feb 2019 15:42:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD31A21A4C for ; Fri, 15 Feb 2019 15:42:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aDwNG08r" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728594AbfBOPmD (ORCPT ); Fri, 15 Feb 2019 10:42:03 -0500 Received: from mail-it1-f169.google.com ([209.85.166.169]:36511 "EHLO mail-it1-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727241AbfBOPmD (ORCPT ); Fri, 15 Feb 2019 10:42:03 -0500 Received: by mail-it1-f169.google.com with SMTP id h6so23041517itl.1 for ; Fri, 15 Feb 2019 07:42:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9WwWqW05rpgElx1oPsRm7uVO2KpbQ5ZjDc7/yCHx62Q=; b=aDwNG08r9fiTFhW+jgx2e0xETDFEd4UPGoVLxeuFyYY8j/AH9lAClTrBJm6pZDopRe DcK8jpHfC7ZFzrLHuAd3erXGCPVBoOCGiS6dqm4lcHyLT9vZnR9l6VW2LHtaAsekkaLl tK29mtXZ+TGfvGwPfdgRmaZFkR0t59f/OOjauP392YK2gMAnOceldMps4kipD3Vc3Nx5 SILQl4hbQsQIBcM3v6KAYHZPtlL/IeUR3frF/JiOsoP3eS4HE5D+4inMrkpWk9CSdnZL /5JCrBEQRBY/V3qwcQRQ/JMxLeZALt3GiVDqZW7dcdk1vnPu0SJ02YCLQu76/KjCFL0p n9hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9WwWqW05rpgElx1oPsRm7uVO2KpbQ5ZjDc7/yCHx62Q=; b=O3MkfrpgnkEIu0BE3EOcjokbKW73VGCXfyZiGFEe1NOjYlcpZHar2JMQHywpR1Gds0 p8GSznFzfbqd4585LI8NPSG57o213qA/lfF5uR01ab68yAJkePXkAhwI8HRb6mah100s l/2ZcuVc7V2RdHGifuoxpzYhvflUemSZML/J87A0nwo5KG3dtdJ+zefBCfR6t6zRhMg6 4pc9229XUps8XDXqQiZ6Ip+SSbio6I4ZXHEPEmYIWmb0OFs1tdY0WBJOmy+FdbGI/Oew tXtaKNVd4+FvUdo/gH+57IGw5t9k65dzwYJzEJX/ZoXvYDdeiVenCRSIS2D8s3vmGeZv IVmg== X-Gm-Message-State: AHQUAuZTxanmLpe7a0AO5pZm75lJyBQFLjHzLsqqEtPQszkC2ZnHR2X6 w9g2oO+ClCvTlKoqqv6Mo7HOPV94g23VmLLafYw= X-Google-Smtp-Source: AHgI3IbEXW6bkMbg1zTmDdB55/NudEwc4ah7ioNET14Aa3XS6AdGKTncalT6W+Uvcv7n4jAFlxkdYGyjdDxGAzn6aqU= X-Received: by 2002:a24:64b:: with SMTP id 72mr5040594itv.59.1550245322766; Fri, 15 Feb 2019 07:42:02 -0800 (PST) MIME-Version: 1.0 References: <1550242187-29660-1-git-send-email-laoar.shao@gmail.com> <1550242187-29660-6-git-send-email-laoar.shao@gmail.com> In-Reply-To: From: Yafang Shao Date: Fri, 15 Feb 2019 23:41:26 +0800 Message-ID: Subject: Re: [net-next 5/5] net: sock: remove the definition of SOCK_DEBUG() To: Eric Dumazet Cc: David Miller , Daniel Borkmann , netdev , shaoyafang@didiglobal.com Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 15, 2019 at 10:58 PM Eric Dumazet wrote: > > On Fri, Feb 15, 2019 at 6:50 AM Yafang Shao wrote: > > > > As SOCK_DEBUG() isn't used any more, we can get ride of it now. > > > > No, we are still using this infrastructure from time to time. > > I told you I agreed to remove the current (obsolete) TCP call sites, > I never suggested to remove SOCK_DEBUG() completely. All right, however I'm not persuaded by you. Because SOCK_DEBUG() is not a smart way for debugging, which requires the user code to be modified. We have other more flexible methords. Thanks Yafang