From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 452C7C46460 for ; Thu, 23 May 2019 20:50:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1BC442075B for ; Thu, 23 May 2019 20:50:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558644645; bh=v6PSwAorcPKsWe7jiuNmsouiSwC/iTj+RqZEfhl5wTU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=p+OTj3IueCM54OnwvBntT+Ju+pMXcFNJ5Up760ays7H/OIDp2Gt6TrNNIx9ohmpBH AC0H6YQcXv9aw9ihITZUUX2aaOKWaMoQIQen/ZH2dIU9um1tQAf98CS6QCQJarqoAR luHdXdyHCIWVz0SZG3lH72cS9BToiyxOcQBWxLeg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387718AbfEWUul (ORCPT ); Thu, 23 May 2019 16:50:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:56590 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731462AbfEWUul (ORCPT ); Thu, 23 May 2019 16:50:41 -0400 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E0BAF217D9; Thu, 23 May 2019 20:50:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558644640; bh=v6PSwAorcPKsWe7jiuNmsouiSwC/iTj+RqZEfhl5wTU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=SMBTwyvzSt1F5ozWUbD29AFuSoG5yodL9g9xTOgk7k4KHvabNSSSBZvOlcJvlCt0d cYISszwzLapIGXwrHlVJbIl9Fvy3QPG6bhkPqkiiPTne0Wr4tMv+JEzPLo5Q4g9QVz aoyz81UXWQSQ5YnefxbKRw75NgYq9Vr7WYCsYzpQ= Received: by mail-qt1-f173.google.com with SMTP id h1so8483611qtp.1; Thu, 23 May 2019 13:50:39 -0700 (PDT) X-Gm-Message-State: APjAAAUCzWeKN7DQ9eZ8ppS3MRvjSxVha8IeCQSWWQSYh0m2BbNwiAQl ZDh+lGXZhDllJy7yKTlEBT59i2j+aeUmRERjUg== X-Google-Smtp-Source: APXvYqyk2vyztm4zwYJzGtYVs0A1UsF2AgpBVYwW7kI4E/hcqrA3rdHk74Zzd/2PUeAN58XxIUsRMSc9Om4BskeB+nQ= X-Received: by 2002:a0c:929a:: with SMTP id b26mr79051384qvb.148.1558644639198; Thu, 23 May 2019 13:50:39 -0700 (PDT) MIME-Version: 1.0 References: <1558611952-13295-1-git-send-email-yash.shah@sifive.com> <1558611952-13295-2-git-send-email-yash.shah@sifive.com> In-Reply-To: <1558611952-13295-2-git-send-email-yash.shah@sifive.com> From: Rob Herring Date: Thu, 23 May 2019 15:50:27 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] net/macb: bindings doc: add sifive fu540-c000 binding To: Yash Shah Cc: David Miller , netdev , "linux-kernel@vger.kernel.org" , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, Mark Rutland , Nicolas Ferre , Palmer Dabbelt , Albert Ou , =?UTF-8?Q?Petr_=C5=A0tetiar?= , Paul Walmsley , Sachin Ghadi Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, May 23, 2019 at 6:46 AM Yash Shah wrote: > > Add the compatibility string documentation for SiFive FU540-C0000 > interface. > On the FU540, this driver also needs to read and write registers in a > management IP block that monitors or drives boundary signals for the > GEMGXL IP block that are not directly mapped to GEMGXL registers. > Therefore, add additional range to "reg" property for SiFive GEMGXL > management IP registers. > > Signed-off-by: Yash Shah > --- > Documentation/devicetree/bindings/net/macb.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt > index 9c5e944..91a2a66 100644 > --- a/Documentation/devicetree/bindings/net/macb.txt > +++ b/Documentation/devicetree/bindings/net/macb.txt > @@ -4,6 +4,7 @@ Required properties: > - compatible: Should be "cdns,[-]{macb|gem}" > Use "cdns,at91rm9200-emac" Atmel at91rm9200 SoC. > Use "cdns,at91sam9260-macb" for Atmel at91sam9 SoCs. > + Use "cdns,fu540-macb" for SiFive FU540-C000 SoC. This pattern that Atmel started isn't really correct. The vendor prefix here should be sifive. 'cdns' would be appropriate for a fallback. > Use "cdns,sam9x60-macb" for Microchip sam9x60 SoC. > Use "cdns,np4-macb" for NP4 SoC devices. > Use "cdns,at32ap7000-macb" for other 10/100 usage or use the generic form: "cdns,macb". > @@ -17,6 +18,8 @@ Required properties: > Use "cdns,zynqmp-gem" for Zynq Ultrascale+ MPSoC. > Or the generic form: "cdns,emac". > - reg: Address and length of the register set for the device > + For "cdns,fu540-macb", second range is required to specify the > + address and length of the registers for GEMGXL Management block. > - interrupts: Should contain macb interrupt > - phy-mode: See ethernet.txt file in the same directory. > - clock-names: Tuple listing input clock names. > -- > 1.9.1 >