From: Rob Herring <robh@kernel.org>
To: Aswath Govindraju <a-govindraju@ti.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Lokesh Vutla <lokeshvutla@ti.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Faiz Abbas <faiz_abbas@ti.com>,
Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Sriram Dash <sriram.dash@samsung.com>,
linux-can@vger.kernel.org, netdev <netdev@vger.kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-phy@lists.infradead.org
Subject: Re: [PATCH 3/4] dt-bindings: net: can: Document transceiver implementation as phy
Date: Wed, 14 Apr 2021 08:24:52 -0500 [thread overview]
Message-ID: <CAL_JsqJ6OW6Pwtj7yTiCguvXDPfMreVpEsxAg59pwfa2qWvqEA@mail.gmail.com> (raw)
In-Reply-To: <e1c2b752-5a2b-e973-c188-5916d8a2e31f@ti.com>
On Wed, Apr 14, 2021 at 1:49 AM Aswath Govindraju <a-govindraju@ti.com> wrote:
>
> Hi Rob,
>
> On 12/04/21 11:21 pm, Rob Herring wrote:
> > On Fri, Apr 09, 2021 at 07:10:53PM +0530, Aswath Govindraju wrote:
> >> From: Faiz Abbas <faiz_abbas@ti.com>
> >>
> >> Some transceivers need a configuration step (for example, pulling the
> >> standby or enable lines) for them to start sending messages. The
> >> transceiver can be implemented as a phy with the configuration done in the
> >> phy driver. The bit rate limitation can the be obtained by the driver using
> >> the phy node.
> >>
> >> Document the above implementation in the bosch mcan bindings
> >>
> >> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> >> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> >> ---
> >> Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> >> index 798fa5fb7bb2..2c01899b1a3e 100644
> >> --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> >> +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> >> @@ -109,6 +109,12 @@ properties:
> >> can-transceiver:
> >> $ref: can-transceiver.yaml#
> >>
> >> + phys:
> >> + minItems: 1
> >
> > maxItems: 1
>
> Will add this in the respin.
>
> >
> >> +
> >> + phy-names:
> >> + const: can_transceiver
> >
> > Kind of a pointless name. You don't really need a name if there's a
> > single entry.
> >
>
> This name used by devm_phy_optional_get() in m_can driver to get the phy
> data structure.
With no name, you'll get the 1st one. Looks like the phy subsystem
warns on this. That's wrong, so please fix that.
Rob
next prev parent reply other threads:[~2021-04-14 13:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 13:40 [PATCH 0/4] CAN TRANSCEIVER: Add support for CAN transceivers Aswath Govindraju
2021-04-09 13:40 ` [PATCH 1/4] dt-bindings: phy: Add binding for TI TCAN104x " Aswath Govindraju
2021-04-12 10:19 ` Marc Kleine-Budde
2021-04-12 17:49 ` Rob Herring
2021-04-13 7:41 ` Marc Kleine-Budde
2021-04-13 13:15 ` Rob Herring
2021-04-14 12:53 ` Aswath Govindraju
2021-04-09 13:40 ` [PATCH 2/4] phy: phy-can-transceiver: Add support for generic CAN transceiver driver Aswath Govindraju
2021-04-12 10:18 ` Marc Kleine-Budde
2021-04-14 6:24 ` Aswath Govindraju
2021-04-14 6:57 ` Marc Kleine-Budde
2021-04-09 13:40 ` [PATCH 3/4] dt-bindings: net: can: Document transceiver implementation as phy Aswath Govindraju
2021-04-12 17:51 ` Rob Herring
2021-04-14 6:49 ` Aswath Govindraju
2021-04-14 13:24 ` Rob Herring [this message]
2021-04-09 13:40 ` [PATCH 4/4] can: m_can_platform: Add support for transceiver " Aswath Govindraju
2021-04-12 10:22 ` Marc Kleine-Budde
2021-04-14 6:59 ` [PATCH 0/4] CAN TRANSCEIVER: Add support for CAN transceivers Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJ6OW6Pwtj7yTiCguvXDPfMreVpEsxAg59pwfa2qWvqEA@mail.gmail.com \
--to=robh@kernel.org \
--cc=a-govindraju@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=faiz_abbas@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=kishon@ti.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lokeshvutla@ti.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=rcsekar@samsung.com \
--cc=sriram.dash@samsung.com \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).