From: Rob Herring <robh+dt@kernel.org>
To: 周琰杰 <zhouyanjie@wanyeetech.com>
Cc: sihui.liu@ingenic.com, David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Giuseppe CAVALLARO <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
netdev <netdev@vger.kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-stm32@st-md-mailman.stormreply.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
dongsheng.qiu@ingenic.com, aric.pzqi@ingenic.com,
rick.tyliu@ingenic.com, jun.jiang@ingenic.com,
sernia.zhou@foxmail.com
Subject: Re: [PATCH v3 1/2] dt-bindings: dwmac: Add bindings for new Ingenic SoCs.
Date: Fri, 18 Jun 2021 13:50:25 -0600 [thread overview]
Message-ID: <CAL_JsqJW_L3TXTy89Y6YOyQzGzOeN3g1D7pwbuGmSW6TFaO4nA@mail.gmail.com> (raw)
In-Reply-To: <20210617112400.5e68c172@zhouyanjie-virtual-machine>
On Wed, Jun 16, 2021 at 9:24 PM 周琰杰 <zhouyanjie@wanyeetech.com> wrote:
>
> Hi Rob,
>
> 于 Wed, 16 Jun 2021 15:45:26 +0800
> 周琰杰 <zhouyanjie@wanyeetech.com> 写道:
>
> > Hi Rob,
> >
> > 于 Tue, 15 Jun 2021 17:05:45 -0600
> > Rob Herring <robh+dt@kernel.org> 写道:
> >
> > > On Mon, Jun 14, 2021 at 11:18 AM 周琰杰 (Zhou Yanjie)
> > > <zhouyanjie@wanyeetech.com> wrote:
> > > >
> > > > Add the dwmac bindings for the JZ4775 SoC, the X1000 SoC,
> > > > the X1600 SoC, the X1830 SoC and the X2000 SoC from Ingenic.
> > > >
> > > > Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> > > > ---
> > > >
> > > > Notes:
> > > > v1->v2:
> > > > No change.
> > > >
> > > > v2->v3:
> > > > Add "ingenic,mac.yaml" for Ingenic SoCs.
> > > >
> > > > .../devicetree/bindings/net/ingenic,mac.yaml | 76
> > > > ++++++++++++++++++++++ .../devicetree/bindings/net/snps,dwmac.yaml
> > > > | 15 +++++ 2 files changed, 91 insertions(+)
> > > > create mode 100644
> > > > Documentation/devicetree/bindings/net/ingenic,mac.yaml
> > > >
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/net/ingenic,mac.yaml
> > > > b/Documentation/devicetree/bindings/net/ingenic,mac.yaml new file
> > > > mode 100644 index 00000000..5fe2e81 --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/net/ingenic,mac.yaml
> > > > @@ -0,0 +1,76 @@
> > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/net/ingenic,mac.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: Bindings for MAC in Ingenic SoCs
> > > > +
> > > > +maintainers:
> > > > + - 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> > > > +
> > > > +description:
> > > > + The Ethernet Media Access Controller in Ingenic SoCs.
> > > > +
> > > > +properties:
> > > > + compatible:
> > > > + enum:
> > > > + - ingenic,jz4775-mac
> > > > + - ingenic,x1000-mac
> > > > + - ingenic,x1600-mac
> > > > + - ingenic,x1830-mac
> > > > + - ingenic,x2000-mac
> > > > +
> > > > + reg:
> > > > + maxItems: 1
> > > > +
> > > > + interrupts:
> > > > + maxItems: 1
> > > > +
> > > > + interrupt-names:
> > > > + const: macirq
> > > > +
> > > > + clocks:
> > > > + maxItems: 1
> > > > +
> > > > + clock-names:
> > > > + const: stmmaceth
> > > > +
> > > > + mode-reg:
> > > > + description: An extra syscon register that control ethernet
> > > > interface and timing delay
> > >
> > > Needs a vendor prefix and type.
> > >
> > > > +
> > > > + rx-clk-delay-ps:
> > > > + description: RGMII receive clock delay defined in pico
> > > > seconds +
> > > > + tx-clk-delay-ps:
> > > > + description: RGMII transmit clock delay defined in pico
> > > > seconds +
> > > > +required:
> > > > + - compatible
> > > > + - reg
> > > > + - interrupts
> > > > + - interrupt-names
> > > > + - clocks
> > > > + - clock-names
> > > > + - mode-reg
> > > > +
> > > > +additionalProperties: false
> > > > +
> > > > +examples:
> > > > + - |
> > > > + #include <dt-bindings/clock/x1000-cgu.h>
> > > > +
> > > > + mac: ethernet@134b0000 {
> > > > + compatible = "ingenic,x1000-mac", "snps,dwmac";
> > >
> > > Doesn't match the schema.
> >
> > Sorry for that, somehow when I run "make dt_bindings_check", there is
> > no warrning or error message about this file. I am sure that yamllint
> > is installed and dtschema has been upgraded to 2021.6.
>
> I found that it seems to be because 5.13 newly introduced
> "DT_CHECKER_FLAGS=-m", and I am still using the old
> "make dt_binding_check" command, so this error is not prompted. Now I
> can see this error message after using the
> "make DT_CHECKER_FLAGS=-m dt_binding_check" command, and I will send a
> fix soon.
No, this error has nothing to do with the '-m' option.
Rob
next prev parent reply other threads:[~2021-06-18 19:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 17:15 [PATCH v3 0/2] Add Ingenic SoCs MAC support 周琰杰 (Zhou Yanjie)
2021-06-14 17:15 ` [PATCH v3 1/2] dt-bindings: dwmac: Add bindings for new Ingenic SoCs 周琰杰 (Zhou Yanjie)
2021-06-14 17:36 ` Andrew Lunn
2021-06-15 14:04 ` Rob Herring
2021-06-15 23:05 ` Rob Herring
2021-06-16 7:45 ` 周琰杰
2021-06-17 3:24 ` 周琰杰
2021-06-18 19:50 ` Rob Herring [this message]
2021-06-14 17:15 ` [PATCH v3 2/2] net: stmmac: Add Ingenic SoCs MAC support 周琰杰 (Zhou Yanjie)
2021-06-14 17:36 ` Andrew Lunn
2021-06-14 20:20 ` [PATCH v3 0/2] " patchwork-bot+netdevbpf
2021-06-15 23:03 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJW_L3TXTy89Y6YOyQzGzOeN3g1D7pwbuGmSW6TFaO4nA@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=alexandre.torgue@st.com \
--cc=aric.pzqi@ingenic.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dongsheng.qiu@ingenic.com \
--cc=joabreu@synopsys.com \
--cc=jun.jiang@ingenic.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=rick.tyliu@ingenic.com \
--cc=sernia.zhou@foxmail.com \
--cc=sihui.liu@ingenic.com \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).