From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE497C43470 for ; Tue, 11 May 2021 13:44:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB4276134F for ; Tue, 11 May 2021 13:44:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231598AbhEKNpv (ORCPT ); Tue, 11 May 2021 09:45:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:52078 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230435AbhEKNpr (ORCPT ); Tue, 11 May 2021 09:45:47 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B210B6192C; Tue, 11 May 2021 13:44:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620740680; bh=0gtK+SJNoRroYqpZxXO9QMth9hd9b/rKhnd/XoT38YQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=XtdoiP0gZ+rKX79UqZPd20HGXRIIbHAbEat0dyEaoYEILdlS7NTlzecb0ZNAtTz+D QTDQkI0+IFO2bK7Gp75kyGNNquowuM0or1pc1U7lsQChETi7OpkSn0jUhptHGIEnuH fSdw21N1Yy6a9RLCO7nrCsICecGVd2N6ChqqFHCqWExI/x6vruXZbT7pkWi7ybGBL/ yjkCaW74hzx3vMwWBNPk068VZOFOOY4qtl4Fa1n7tsmN7cSzKlxpF537QtwpZEIN+2 HE5PQ+TCm45etli8n07f9d11NoKPQFtNGbsUSyvk63KV+eD5UNOX08H3g78nzwvkz/ nmLkXeJudMjqw== Received: by mail-ej1-f48.google.com with SMTP id l4so29826903ejc.10; Tue, 11 May 2021 06:44:40 -0700 (PDT) X-Gm-Message-State: AOAM531Zv7GmCgnjue9eC2Gtvm/hWAcrIcWByrtay8A9SUWNrpGQlOA+ v9Ek+SBLAOePWx35qvwNm4IO9Q7V1wgyYHpdWA== X-Google-Smtp-Source: ABdhPJyrWgIUlnOMhVp7YSyR/CWZOr54gf3UNB1vwdQnelxzeEkHmRrxQ841ilXDozmbXutGgeZtxVaJ2xxtGRrkxgg= X-Received: by 2002:a17:906:dbdc:: with SMTP id yc28mr11876880ejb.130.1620740679070; Tue, 11 May 2021 06:44:39 -0700 (PDT) MIME-Version: 1.0 References: <20210510204524.617390-1-robh@kernel.org> In-Reply-To: From: Rob Herring Date: Tue, 11 May 2021 08:44:25 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] dt-bindings: More removals of type references on common properties To: Luca Ceresoli Cc: devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Stephen Boyd , Olivier Moysan , Arnaud Pouliquen , Jonathan Cameron , Lars-Peter Clausen , Dmitry Torokhov , Bjorn Andersson , Georgi Djakov , "David S. Miller" , Jakub Kicinski , Sebastian Reichel , Orson Zhai , Baolin Wang , Chunyan Zhang , Liam Girdwood , Mark Brown , Fabrice Gasnier , Odelu Kukatla , Alex Elder , Shengjiu Wang , linux-clk , Linux-ALSA , "open list:IIO SUBSYSTEM AND DRIVERS" , linux-arm-kernel , Linux Input , "open list:THERMAL" , netdev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, May 11, 2021 at 2:20 AM Luca Ceresoli wrote: > > Hi, > > On 10/05/21 22:45, Rob Herring wrote: > > Users of common properties shouldn't have a type definition as the > > common schemas already have one. A few new ones slipped in and > > *-names was missed in the last clean-up pass. Drop all the unnecessary > > type references in the tree. > > > > A meta-schema update to catch these is pending. > > > > Cc: Luca Ceresoli > > Cc: Stephen Boyd > > Cc: Olivier Moysan > > Cc: Arnaud Pouliquen > > Cc: Jonathan Cameron > > Cc: Lars-Peter Clausen > > Cc: Dmitry Torokhov > > Cc: Bjorn Andersson > > Cc: Georgi Djakov > > Cc: "David S. Miller" > > Cc: Jakub Kicinski > > Cc: Sebastian Reichel > > Cc: Orson Zhai > > Cc: Baolin Wang > > Cc: Chunyan Zhang > > Cc: Liam Girdwood > > Cc: Mark Brown > > Cc: Fabrice Gasnier > > Cc: Odelu Kukatla > > Cc: Alex Elder > > Cc: Shengjiu Wang > > Cc: linux-clk@vger.kernel.org > > Cc: alsa-devel@alsa-project.org > > Cc: linux-iio@vger.kernel.org > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-input@vger.kernel.org > > Cc: linux-pm@vger.kernel.org > > Cc: netdev@vger.kernel.org > > Signed-off-by: Rob Herring > > --- > > Documentation/devicetree/bindings/clock/idt,versaclock5.yaml | 2 -- > > .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 1 - > > Documentation/devicetree/bindings/input/input.yaml | 1 - > > Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml | 1 - > > Documentation/devicetree/bindings/net/qcom,ipa.yaml | 1 - > > .../devicetree/bindings/power/supply/sc2731-charger.yaml | 2 +- > > Documentation/devicetree/bindings/sound/fsl,rpmsg.yaml | 2 +- > > 7 files changed, 2 insertions(+), 8 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml > > index c268debe5b8d..28675b0b80f1 100644 > > --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml > > +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml > > @@ -60,7 +60,6 @@ properties: > > maxItems: 2 > > > > idt,xtal-load-femtofarads: > > - $ref: /schemas/types.yaml#/definitions/uint32 > > minimum: 9000 > > maximum: 22760 > > description: Optional load capacitor for XTAL1 and XTAL2 > > @@ -84,7 +83,6 @@ patternProperties: > > enum: [ 1800000, 2500000, 3300000 ] > > idt,slew-percent: > > description: The Slew rate control for CMOS single-ended. > > - $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [ 80, 85, 90, 100 ] > > Ok, but shouldn't "percent" be listed in > Documentation/devicetree/bindings/property-units.txt? It is in the schema already[1]. > Reviewed-by: Luca Ceresoli Thanks. Rob [1] https://github.com/devicetree-org/dt-schema/blob/master/schemas/property-units.yaml