From: Adrian Pop <popadrian1996@gmail.com>
To: Ido Schimmel <idosch@idosch.org>
Cc: netdev@vger.kernel.org, linville@tuxdriver.com,
davem@davemloft.net, kuba@kernel.org, jiri@mellanox.com,
vadimp@mellanox.com, mlxsw@mellanox.com,
Ido Schimmel <idosch@mellanox.com>, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH] ethtool: Add QSFP-DD support
Date: Tue, 4 Aug 2020 09:23:28 +0100 [thread overview]
Message-ID: <CAL_jBfSMe5YDxsKgdX8yD+2yjdQ7LCm3BVi22F+NZ7L1dJm+Ww@mail.gmail.com> (raw)
In-Reply-To: <20200804074413.GA2534462@shredder>
Hi Andrew, Ido!
> Hi Adrian, thanks again for submitting this patch. I got two comments
> off-list. Sharing them here.
Thanks for pointing that out, I took a look and you're right. I'll fix them.
> Didn't we discuss that page 3 might be useful? I would prefer not to
> document that pages 0x10 and 0x11 would follow page 2 until we have a
> driver which does actually provide pages 0x10 and 0x11.
Should I just remove that bit about 0x10 and 0x11 from the commit
message (so keep only the first two paragraphs) and leave the code as
it is?
Adrian
next prev parent reply other threads:[~2020-08-04 8:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 8:47 [PATCH] ethtool: Add QSFP-DD support Adrian Pop
2020-08-02 16:55 ` Andrew Lunn
2020-08-04 7:44 ` Ido Schimmel
2020-08-04 8:23 ` Adrian Pop [this message]
2020-08-04 10:14 ` Michal Kubecek
2020-08-04 10:25 ` Adrian Pop
2020-08-04 17:18 ` Michal Kubecek
2020-08-06 15:13 ` Adrian Pop
2020-08-04 10:30 ` Michal Kubecek
-- strict thread matches above, loose matches on Subject: below --
2019-11-09 12:42 Adrian Pop
2019-11-09 15:33 ` Andrew Lunn
[not found] ` <CAL_jBfQhVAy24xbz_VbpPM0QtRu-Uzawhyn=AY0b41B9=v3Ytg@mail.gmail.com>
2019-11-13 13:59 ` Andrew Lunn
2019-11-15 19:00 ` Adrian Pop
[not found] ` <20191115201508.GF24205@lunn.ch>
2019-11-15 21:34 ` Adrian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_jBfSMe5YDxsKgdX8yD+2yjdQ7LCm3BVi22F+NZ7L1dJm+Ww@mail.gmail.com \
--to=popadrian1996@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=linville@tuxdriver.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).