netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adrian Pop <popadrian1996@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
	jiri@mellanox.com, vadimp@mellanox.com, mlxsw@mellanox.com,
	Ido Schimmel <idosch@mellanox.com>,
	Roopa Prabhu <roopa@nvidia.com>,
	Paul Schmidt <paschmidt@nvidia.com>
Subject: Re: [PATCH ethtool v2] Add QSFP-DD support
Date: Thu, 13 Aug 2020 10:23:17 +0300	[thread overview]
Message-ID: <CAL_jBfTUpcooEMdcaj1QsvGkD2AP_w+WzyZAzTr9nR4_6FNzHQ@mail.gmail.com> (raw)
In-Reply-To: <20200808143047.GG2028541@lunn.ch>

Hi Andrew!

I removed all the comments/constants/structs/functions that were
assuming the existence of page 0x10 and 0x11. I sent v3 to Ido (before
submitting it), he helped me test it and everything works fine. Please
let me know if there's anything else that should be changed.

Also, I just noticed I forgot to sign-off the patch. Can the following
lines be added by you or it's me who needs to add them by
re-submitting?
Signed-off-by: Adrian Pop <popadrian1996@gmail.com>
Tested-by: Ido Schimmel <idosch@mellanox.com>

Thank you!
Adrian

On Sat, 8 Aug 2020 at 17:30, Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Thu, Aug 06, 2020 at 07:21:21PM +0300, Adrian Pop wrote:
> > Hi Andrew!
> >
> > Should I resubmit v3 after I delete the code that has to do with page
> > 0x10 and 0x11?
>
> Yes please.
>
>     Andrew

      reply	other threads:[~2020-08-13  9:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-06 14:59 [PATCH ethtool v2] Add QSFP-DD support Adrian Pop
2020-08-06 18:07 ` Andrew Lunn
2020-08-06 16:21   ` Adrian Pop
2020-08-08 14:30     ` Andrew Lunn
2020-08-13  7:23       ` Adrian Pop [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_jBfTUpcooEMdcaj1QsvGkD2AP_w+WzyZAzTr9nR4_6FNzHQ@mail.gmail.com \
    --to=popadrian1996@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=idosch@mellanox.com \
    --cc=jiri@mellanox.com \
    --cc=kuba@kernel.org \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=paschmidt@nvidia.com \
    --cc=roopa@nvidia.com \
    --cc=vadimp@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).