From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Herbert Subject: Re: [patch net-next 00/15] introduce programable flow dissector and cls_flower Date: Sat, 9 May 2015 14:29:49 -0700 Message-ID: References: <1431177038-11555-1-git-send-email-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Linux Kernel Network Developers , "David S. Miller" , Jamal Hadi Salim , Thomas Graf , jesse@nicira.com, Patrick McHardy , Tom Herbert , Eric Dumazet , alexander.h.duyck@redhat.com, Hannes Frederic Sowa , Alexei Starovoitov , daniel@iogearbox.net, Herbert Xu , cwang@twopensource.com, john fastabend To: Jiri Pirko Return-path: Received: from mail-ig0-f171.google.com ([209.85.213.171]:33772 "EHLO mail-ig0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751848AbbEIV3u (ORCPT ); Sat, 9 May 2015 17:29:50 -0400 Received: by igbpi8 with SMTP id pi8so50443152igb.0 for ; Sat, 09 May 2015 14:29:49 -0700 (PDT) In-Reply-To: <1431177038-11555-1-git-send-email-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org List-ID: On Sat, May 9, 2015 at 6:10 AM, Jiri Pirko wrote: > Per Davem's request, I prepared this patchset which introduces programmable > flow dissector. For current users of flow_keys, there is a wrapper > skb_flow_dissect_flow_keys which maintains the previous behaviour. > For purposes of cls_flower, couple of new dissection keys were introduced. > Jiri, Did you see my comments on the previous version and my patchset that includes full IPv6 addresses in flow keys and hashes over them? Tom > Note that this dissector can be also eventually used by openvswitch code. > > Also, as a next step, I plan to get rid of *skb_flow_get_ports(export) > and *__skb_get_poff as their functionality can be now implemented by > skb_flow_dissect as well. > > rfc->v1: > - only rebase > > Jiri Pirko (15): > net: change name of flow_dissector header to match the .c file name > flow_dissector: remove unused function flow_get_hlen declaration > net: move *skb_get_poff declarations into correct header > flow_dissector: fix doc for __skb_get_hash and remove couple of empty > lines > net: move __skb_get_hash function declaration to flow_dissector.h > net: move __skb_tx_hash to skbuff.c > net: move netdev_pick_tx and dependencies to net/core/dev.c > flow_dissector: fix doc for skb_get_poff > flow_dissector: introduce programable flow_dissector > flow_dissect: use programable dissector in skb_flow_dissect and > friends > flow_dissector: add missing header includes > flow_dissector: introduce support for ipv6 addressses > flow_dissector: introduce support for Ethernet addresses > flow_dissector: change port array into src,dst tuple > tc: introduce Flower classifier > > drivers/net/bonding/bond_main.c | 20 +- > drivers/net/ethernet/cisco/enic/enic_clsf.c | 29 +- > drivers/net/ethernet/cisco/enic/enic_ethtool.c | 10 +- > drivers/net/hyperv/netvsc_drv.c | 8 +- > include/linux/skbuff.h | 11 +- > include/net/flow_dissector.h | 167 ++++++ > include/net/flow_keys.h | 61 --- > include/net/ip.h | 10 +- > include/net/ipv6.h | 10 +- > include/uapi/linux/pkt_cls.h | 31 ++ > net/core/dev.c | 78 +++ > net/core/filter.c | 1 + > net/core/flow_dissector.c | 380 ++++++++------ > net/core/skbuff.c | 28 + > net/ethernet/eth.c | 7 +- > net/sched/Kconfig | 10 + > net/sched/Makefile | 1 + > net/sched/cls_flow.c | 22 +- > net/sched/cls_flower.c | 688 +++++++++++++++++++++++++ > net/sched/sch_choke.c | 6 +- > 20 files changed, 1283 insertions(+), 295 deletions(-) > create mode 100644 include/net/flow_dissector.h > delete mode 100644 include/net/flow_keys.h > create mode 100644 net/sched/cls_flower.c > > -- > 1.9.3 > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html