From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38054C5AE5E for ; Sat, 19 Jan 2019 00:45:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EAC542086D for ; Sat, 19 Jan 2019 00:45:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=dev-mellanox-co-il.20150623.gappssmtp.com header.i=@dev-mellanox-co-il.20150623.gappssmtp.com header.b="eC9bHDog" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727109AbfASApn (ORCPT ); Fri, 18 Jan 2019 19:45:43 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:40533 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726033AbfASApn (ORCPT ); Fri, 18 Jan 2019 19:45:43 -0500 Received: by mail-lj1-f193.google.com with SMTP id n18-v6so13102213lji.7 for ; Fri, 18 Jan 2019 16:45:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dev-mellanox-co-il.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VC2eAEb+yNDkIA/nwdrLzkL0iIk3pLDW3OglFgv0AeA=; b=eC9bHDogJYLhXja3pHW3jkEnnyU1Bc+1rl+//oPRW0FsTCbH5oc5Ivj15xNL5dYnZs XGgPq2kdGpgbsYCn1BPFo/06cetQF0DHxqXomuxQGWpzd9mD8Oj16C8MCNSotO1UNJMq QUJs/CvuOKAz/5mpRroKv/Vrl4K0nSLAmTzWYXL6XEZFiLQxqlqqAwJDYxl8ZHVXEoi5 UWqypNlOU9ilWsHXCGis4hiE+ebjJB70IKK2o30P3TMVE9Mrr6+0DT9GPUr9Val15CB3 liybBY+hozq/IscxPQZXOsCrF3WTJ87gyW9HISs8L8HkU/fXzAYgcKNfa6rhaNoQK1Qo P6kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VC2eAEb+yNDkIA/nwdrLzkL0iIk3pLDW3OglFgv0AeA=; b=QWxcJ8qT4ROyGdRwnEzxNjt3JLYiPi1Br21pWK+PCcCz4y/ghGHcQVBWt6scKSvQlH APOWiPL/hLky0Na6gX6ZkyBbkccwb54EHBPse2voIhzpIYX9PcsZpEGXKDXa6rCBJYbW IUUGf0B8P0lhpKA4uIPnCi2f7GVpjpUhmu3wCYSpOJJwJRoVaoF5LB0l4LKb7x4K2X9R 7WDO3/wN8uzOgbDgU8RI6f+k+Rjhmd8+qGIeKYSnJosmLgzgC2RWxp9m7rKACZ2GAv7t Uhe8WZXhan3Leja9/yTECrt+gCqSFzadT9VjkGN1H7qghg+jwQEW2fzrhF+1ZIrmhhRI 6YCQ== X-Gm-Message-State: AJcUukezyK3n2OUGNe/QwLmKQ6HrM4fB791EWgVnsLYp5oRQcAiBD37T KwFHdiW48HI3iSaA9gxbzSONY6jClriTjsFMBAFb0g== X-Google-Smtp-Source: ALg8bN64jATB9fC7pvlPMD+pdawUrxq7p415Ls/TrnyewYynYmaXsDLkRLzUhI/avFOsuORjtXRD3i+GnwhK4G5NGGk= X-Received: by 2002:a2e:84ca:: with SMTP id q10-v6mr13090187ljh.65.1547858741040; Fri, 18 Jan 2019 16:45:41 -0800 (PST) MIME-Version: 1.0 References: <20181128061013.3885-1-xiyou.wangcong@gmail.com> <20181203.151724.648093455366632499.davem@davemloft.net> <20181213084010.GB6169@pcnci.linuxbox.cz> <20190105183518.GA29754@localhost.localdomain> In-Reply-To: From: Saeed Mahameed Date: Fri, 18 Jan 2019 16:45:30 -0800 Message-ID: Subject: Re: [Patch net v2] mlx5: fixup checksum for short ethernet frame padding To: Christoph Paasch Cc: Nikola Ciprich , Saeed Mahameed , "davem@davemloft.net" , "netdev@vger.kernel.org" , "xiyou.wangcong@gmail.com" , "edumazet@google.com" Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jan 17, 2019 at 5:19 PM Christoph Paasch wrote: > > Hello, > > On Sun, Jan 6, 2019 at 3:12 AM Saeed Mahameed wrote: > > > > On Sat, Jan 5, 2019 at 8:35 PM Nikola Ciprich > > wrote: > > > > > > Hi Saeed, > > > > > > > > > > Most likely the same issue, we are finalizing the patch initially > > > > proposed by Cong, you can find it here, I plan to submit it next week, > > > > after all the regression tests. > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git/commit/?h=topic/csum-fix > > > > > > > > It would be nice if you verify this fixes your issue. > > > > > > I tried 4.20.0 + this fix and the problems are gone! haven't done backport to 4.19 yet. > > > > > > cheers! > > > > Thanks nik for your input, we will submit a similar fix very soon. > > We are also seeing similar issues on v4.14.94, as Eric's patch got > backported with 6bf32cda46eb. > > I backported (had to do some changes to solve the conflicts) your fix > from topic/csum-fix to v4.14.94, but then I still get the warning when > the frame is bigger than ETH_ZLEN (which is quite unsurprising ;-)). Hi Christoph, This is a bummer, we only saw the issue with switches that are padding packets up to ETH_ZLEN, and they never touch packets larger than this size, still i agree that the issue could happen with any packet size, we just never saw such hardware/switch which produces packets with non-zero end padding! the only option i can suggest is to disable checksum complete, it can be done via a priv-flag which was submitted to kernel v4.20. commit b856df28f9230a47669efbdd57896084caadb2b3 Author: Or Gerlitz Date: Sun Jul 1 08:58:38 2018 +0000 net/mlx5e: Allow reporting of checksum unnecessary Currently we practically never report checksum unnecessary, because for all IP packets we take the checksum complete path. Enable non-default runs with reprorting checksum unnecessary, using an ethtool private flag. This can be useful for performance evals and other explorations. Signed-off-by: Or Gerlitz Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed > Eric already pointed that out that one can cook bigger frames with > padding (cfr., https://patchwork.ozlabs.org/patch/1004117/). > > What is the plan to get rid of the warning in v4.14-stable? > > > Thanks, > Christoph > > > > > > > > > > > nik > > > > > > > > > > > > > > > > > Thanks, > > > > Saeed. > > > > > > > > > > > > > thanks a lot in advance > > > > > > > > > > BR > > > > > > > > > > nik > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > Saeed. > > > > > > > > > > > > > > > > -- > > > ------------------------------------- > > > Ing. Nikola CIPRICH > > > LinuxBox.cz, s.r.o. > > > 28. rijna 168, 709 00 Ostrava > > > > > > tel.: +420 591 166 214 > > > fax: +420 596 621 273 > > > mobil: +420 777 093 799 > > > > > > www.linuxbox.cz > > > > > > mobil servis: +420 737 238 656 > > > email servis: servis@linuxbox.cz > > > -------------------------------------