archive mirror
 help / color / mirror / Atom feed
From: Jamal Hadi Salim <>
To: Thadeu Lima de Souza Cascardo <>
Cc:, Cong Wang <>,
	Jiri Pirko <>,
	Zhenpeng Lin <>,
	Kamal Mostafa <>,
Subject: Re: [PATCH] net_sched: cls_route: remove from list when handle is 0
Date: Tue, 9 Aug 2022 15:11:44 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Aug 9, 2022 at 1:06 PM Thadeu Lima de Souza Cascardo
<> wrote:
> When a route filter is replaced and the old filter has a 0 handle, the old
> one won't be removed from the hashtable, while it will still be freed.
> The test was there since before commit 1109c00547fc ("net: sched: RCU
> cls_route"), when a new filter was not allocated when there was an old one.
> The old filter was reused and the reinserting would only be necessary if an
> old filter was replaced. That was still wrong for the same case where the
> old handle was 0.
> Remove the old filter from the list independently from its handle value.
> This fixes CVE-2022-2588, also reported as ZDI-CAN-17440.
> Reported-by: Zhenpeng Lin <>
> Signed-off-by: Thadeu Lima de Souza Cascardo <>
> Reviewed-by: Kamal Mostafa <>
> Cc: <>
> Cc: Jamal Hadi Salim <>

Acked-by: Jamal Hadi Salim <>


  reply	other threads:[~2022-08-09 19:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09 17:05 [PATCH] net_sched: cls_route: remove from list when handle is 0 Thadeu Lima de Souza Cascardo
2022-08-09 19:11 ` Jamal Hadi Salim [this message]
2022-08-11  6:10 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).