netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taehee Yoo <ap420073@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: David Miller <davem@davemloft.net>,
	subashab@codeaurora.org, stranche@codeaurora.org,
	Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/3] net: rmnet: print error message when command fails
Date: Thu, 5 Mar 2020 07:56:02 +0900	[thread overview]
Message-ID: <CAMArcTW=bNXLQ=VJt8eLSX7x2ne+V3JqkAUD3fB1kCeo8ubVMg@mail.gmail.com> (raw)
In-Reply-To: <20200304120100.369c6de7@kicinski-fedora-PC1C0HJN>

On Thu, 5 Mar 2020 at 05:01, Jakub Kicinski <kuba@kernel.org> wrote:
>

Hi Jakub,
Thank you for the review

> On Wed,  4 Mar 2020 07:51:02 +0000 Taehee Yoo wrote:
> > @@ -263,12 +262,16 @@ static int rmnet_rtnl_validate(struct nlattr *tb[], struct nlattr *data[],
> >  {
> >       u16 mux_id;
> >
> > -     if (!data || !data[IFLA_RMNET_MUX_ID])
> > +     if (!data || !data[IFLA_RMNET_MUX_ID]) {
> > +             NL_SET_ERR_MSG_MOD(extack, "MUX ID not specifies");
> >               return -EINVAL;
> > +     }
>
> nit: typo in specified ?

Okay, I will change this message.

Thank you!
Taehee Yoo

  reply	other threads:[~2020-03-04 22:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04  7:51 [PATCH net-next 2/3] net: rmnet: print error message when command fails Taehee Yoo
2020-03-04 20:01 ` Jakub Kicinski
2020-03-04 22:56   ` Taehee Yoo [this message]
2020-03-04 20:47 ` subashab
2020-03-04 22:57   ` Taehee Yoo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMArcTW=bNXLQ=VJt8eLSX7x2ne+V3JqkAUD3fB1kCeo8ubVMg@mail.gmail.com' \
    --to=ap420073@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stranche@codeaurora.org \
    --cc=subashab@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).