From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFF9AC3F2CE for ; Wed, 4 Mar 2020 22:58:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8988120848 for ; Wed, 4 Mar 2020 22:58:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DU5MsYoa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388488AbgCDW6H (ORCPT ); Wed, 4 Mar 2020 17:58:07 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:41511 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387931AbgCDW6H (ORCPT ); Wed, 4 Mar 2020 17:58:07 -0500 Received: by mail-lf1-f67.google.com with SMTP id y17so2910597lfe.8 for ; Wed, 04 Mar 2020 14:58:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A1WuBGhpwOOTY60Brcp+ApzkR+gO0sOpMx89fTUxTwo=; b=DU5MsYoayOBpffAIs4XljIQdjIONhrTykC+D5i+CK8j8HlOkidRpWtwfZ4w19qEfed idf6KeBYc1SCbzeigYoReBK8V3tplblEEYDpCpfoEE76RopeIQObAGgQBybYtg5Pv2Am o1JqJIDTUq/jtEKdq1fScsNsyRN34GAt1f7mlvEJ33hYpTsgsDabRyo6sIbPG+n/Czsn 1mFRC7kATxEKbfKEVEqLl0eOXp0Wq7/siZU+74+7tizHTH878TEkpxaGlgvdwbshAbwg OAKC0x0UKOHwfz87USPCmWWP3at0K4+oJd9lJlbikJEUq0Al9G8kkWylkK7LeMBb948m +TdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A1WuBGhpwOOTY60Brcp+ApzkR+gO0sOpMx89fTUxTwo=; b=ugbGx3hOK5i5LoE7M0VeMX0OQLJxgII/KranfJEVQZ41IZQ52PHUAmubdbgcGyow7/ ki4RPAzhj40pogrpjYI9uPO6o/5FG0p3jmYFllFjXT4k1GqvvX49KYtexaeJzo8Co+ZK NA681+r9DCI5Ul5EgcDHV7G4/exwLejiI/TPwgpG3m9eyglK39Hn8CTLoHs2lb0/aYZl J/y+5606HtYHPUleJtGJxOlmjv2Pvz1htUyqqNPTFeX92YGYJ7oOhDj19wuxXdbr40C0 m5hY0cLTYMfUnNHjuo9Hb0Nqu0uy6/d53R7ASJQ35Stab5EwfA9CNM+JDPi+JK65hUHI Aiaw== X-Gm-Message-State: ANhLgQ30A+OyveKPJm5xJ4paPSVhclqsd/QvvjxtCns9K/do+3zAKWQm YT46WEjDkBu7gI6aHEKW5ASmYp3s1sA1cVRlvTQ= X-Google-Smtp-Source: ADFU+vsGieHJ/geDTs1qMNlA3X3TtBmgX7AaYAajaYE/YzTUnEa5uDFcFKq20xp6j5Tre4dW9xJecigurjftFjDx9KI= X-Received: by 2002:a19:c20b:: with SMTP id l11mr3295861lfc.135.1583362685626; Wed, 04 Mar 2020 14:58:05 -0800 (PST) MIME-Version: 1.0 References: <20200304075102.23430-1-ap420073@gmail.com> In-Reply-To: From: Taehee Yoo Date: Thu, 5 Mar 2020 07:57:54 +0900 Message-ID: Subject: Re: [PATCH net-next 2/3] net: rmnet: print error message when command fails To: subashab@codeaurora.org Cc: David Miller , Jakub Kicinski , stranche@codeaurora.org, Netdev Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 5 Mar 2020 at 05:47, wrote: > Hi Subash, Thank you for your review > > + if (rmnet_is_real_dev_registered(slave_dev)) { > > + NL_SET_ERR_MSG_MOD(extack, > > + "dev is already attached another rmnet dev"); > > > Hi Taehee > > Can you make this change as well- > "slave cannot be another rmnet dev" Okay, I will change this message too. Thank you! Taehee Yoo