From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DBDCC43381 for ; Sat, 23 Feb 2019 07:58:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF2BB206BA for ; Sat, 23 Feb 2019 07:58:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ez8rf/jX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725963AbfBWH6l (ORCPT ); Sat, 23 Feb 2019 02:58:41 -0500 Received: from mail-ot1-f65.google.com ([209.85.210.65]:38493 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725868AbfBWH6l (ORCPT ); Sat, 23 Feb 2019 02:58:41 -0500 Received: by mail-ot1-f65.google.com with SMTP id m1so3909247otf.5 for ; Fri, 22 Feb 2019 23:58:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hhrQp/2wUYT+rU8Vo3AjI9Stp6p8Ioi8X3T5bBEBqU0=; b=ez8rf/jXZ41TpWOGTLvOiRiZ9Y+Y2PjwerQZI/H4IybkggRAsAceVggceY4BY0rRl3 iJvvYVIw/369RzOTcXO/Foul51r5S5xWHzwkydNvLZ0qwb+/g0g58FMdpdicCQHDr3tJ UNX41ZGwX5RW3U5ozv7vH9zEyzv2qlA1YzXZqLzqRBCxd6YTiwvmjvHrZBDvh4jFOnRK j99d8cN3gEu+5I2i6XDNesPkY3m3qLHLqBPD3eECqzrArRB7ZuhqgZ5CFzWUqJmyuB0i xriFyZAW9mbMfiRZnir49NmLx1WLfxfSsgaAnIPFne9WxS7iCQdIwLWBcZNc/Tlzh/ki nQgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hhrQp/2wUYT+rU8Vo3AjI9Stp6p8Ioi8X3T5bBEBqU0=; b=B+z4XRfLKvxYBsKzwn56XlcjiO0ABUHKtccKoZsfW9HfzkTUhFjvsYsJkD6RGLhAiX jHPwFH5FuFLZb23U0tUjxYTG1EFHimwpRzz9EHzsQ584OGxc1RHVAn/Rkv4k3D3Jejsy XCfJJHpTocgLOKyy6FCRpRrXL4cmdjgg6kFjoucrH6irCSVCB8+2KVEIsN8Ny/l9Uepa 9M/QdgD8KuCVz7wqho2Up/5bSyuAxqqgbIGJ8zDHHZ9OJoXt8Aw3H6wF6Q4KEF+UPrJB Tu5N8pPHX6WqU3nRqgn1C8wdTj9fPmZRfYjR+44Ic4p+HtcLPn+kdw/GXuxcgzIZ751H hA7w== X-Gm-Message-State: AHQUAuYiCzGRjEcp0ynHZIgRyo3HSx0nZ5T7oV/CC0zIfH7UezIrwlJS CmfIdunbmka04z6+tZkWLXCRrl/iNhNapna6pMY= X-Google-Smtp-Source: AHgI3IbRJIhXctNxDNCoAM0NQG1xGg6enwcajUtIuMFgUwMMtkS8b13bclCLiQBAq54jrtMPWdF8TpO/S5NR5wz71aI= X-Received: by 2002:a9d:7f10:: with SMTP id j16mr5328556otq.297.1550908720232; Fri, 22 Feb 2019 23:58:40 -0800 (PST) MIME-Version: 1.0 References: <1550715283-23579-1-git-send-email-xiangxia.m.yue@gmail.com> <1550715283-23579-2-git-send-email-xiangxia.m.yue@gmail.com> In-Reply-To: From: Tonghao Zhang Date: Sat, 23 Feb 2019 15:58:04 +0800 Message-ID: Subject: Re: [PATCH net-next 2/5] net/mlx5e: Make the log friendly when decapsulation offload not supported To: Or Gerlitz Cc: Saeed Mahameed , Linux Netdev List Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 22, 2019 at 5:07 PM Or Gerlitz wrote: > > On Fri, Feb 22, 2019 at 9:49 AM Tonghao Zhang wrote: > > > > On Fri, Feb 22, 2019 at 12:32 AM Or Gerlitz wrote: > > > > > > On Thu, Feb 21, 2019 at 3:42 PM wrote: > > > > > > > > From: Tonghao Zhang > > > > > > > > If we try to offload decapsulation actions to VFs hw, we get the log [1]. > > > > > > but the switching was on the tunnel type (if (tunnel_type == [...]) - > > Yes, but we try to offload tc flow to VF device. For example > > the p2p1_0 is VF, but not rep > > so this should go to the nic and not esw tc offload code path in en_tc.c nic and esw will call parse_cls_flower() to parse the flower flows, and more information is shown as below. > and the nic path (look for parse_tc_nic_actions or a like) doesn't have > a case for the tunnel key action - you should not have got to this code > at all, please look deeper to realize what is going on there, maybe p2p1_0 > is a rep? what does ip -d link show gives on it? # ip -d link 14: eth0_p1: mtu 1500 qdisc mq state UP mode DEFAULT group default qlen 1000 link/ether 98:03:9b:06:d9:09 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 9978 addrgenmode none numtxqueues 128 numrxqueues 16 gso_max_size 65536 gso_max_segs 65535 portname p1 switchid 98039b06d909 vf 0 MAC 00:11:22:33:44:00, spoof checking off, link-state auto, trust off, query_rss off vf 1 MAC 00:11:22:33:44:01, spoof checking off, link-state auto, trust off, query_rss off 15: eth0_pf1vf0: mtu 1500 qdisc mq state UP mode DEFAULT group default qlen 1000 link/ether 8a:26:c0:33:17:2c brd ff:ff:ff:ff:ff:ff promiscuity 1 minmtu 68 maxmtu 9978 addrgenmode none numtxqueues 16 numrxqueues 16 gso_max_size 65536 gso_max_segs 65535 portname pf1vf0 switchid 98039b06d909 16: eth0_pf1vf1: mtu 1500 qdisc mq state UP mode DEFAULT group default qlen 1000 link/ether 96:34:55:5b:42:80 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 9978 addrgenmode none numtxqueues 16 numrxqueues 16 gso_max_size 65536 gso_max_segs 65535 portname pf1vf1 switchid 98039b06d909 17: p2p1_0: mtu 1500 qdisc mq state UP mode DEFAULT group default qlen 1000 link/ether 00:11:22:33:44:00 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 9978 addrgenmode none numtxqueues 64 numrxqueues 8 gso_max_size 65536 gso_max_segs 65535 18: p2p1_1: mtu 1500 qdisc mq state UP mode DEFAULT group default qlen 1000 link/ether 00:11:22:33:44:01 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 9978 addrgenmode none numtxqueues 64 numrxqueues 8 gso_max_size 65536 gso_max_segs 65535 # ethtool -i p2p1_0 driver: mlx5_core version: 5.0-0 firmware-version: 14.24.1000 (MT_2420110034) bus-info: 0000:05:01.2 supports-statistics: yes supports-test: yes supports-eeprom-access: no supports-register-dump: no supports-priv-flags: yes # ethtool -i eth0_pf1vf0 driver: mlx5e_rep version: 5.0.0-rc7+ firmware-version: bus-info: supports-statistics: yes supports-test: no supports-eeprom-access: no supports-register-dump: no supports-priv-flags: no the call trace: [ 586.669600] dump_stack+0x5a/0x73 [ 586.669651] mlx5e_tc_tun_parse+0x2c6/0x3a0 [mlx5_core] [ 586.669682] __parse_cls_flower.constprop.48+0x1b2/0xca0 [mlx5_core] [ 586.669746] parse_cls_flower+0x5d/0x110 [mlx5_core] [ 586.669771] mlx5e_configure_flower+0x40a/0x760 [mlx5_core] [ 586.669779] tc_setup_cb_call+0x55/0x80 [ 586.669787] fl_change+0x12a1/0x16b8 [cls_flower] [ 586.669797] tc_new_tfilter+0x570/0x890 [ 586.669808] rtnetlink_rcv_msg+0xed/0x320 [ 586.669817] netlink_rcv_skb+0xcb/0x100 [ 586.669822] netlink_unicast+0x17f/0x230 [ 586.669827] netlink_sendmsg+0x2d2/0x3d0