From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
To: William Tu <u9012063@gmail.com>
Cc: ovs dev <dev@openvswitch.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Greg Rose <gvrose8192@gmail.com>,
Eelco Chaudron <echaudro@redhat.com>,
pravin shelar <pshelar@ovn.org>
Subject: Re: [ovs-dev] [PATCH net-next 0/9] optimize openvswitch flow looking up
Date: Tue, 8 Oct 2019 09:41:09 +0800 [thread overview]
Message-ID: <CAMDZJNX6vmouP_EDx2JMyXb6qOnXKk6XjwNDaz8mjWYVtvw7nA@mail.gmail.com> (raw)
In-Reply-To: <CALDO+SYW1-Or7z93+qzKvx-wtMAH-h1fpsTcPCXNuWDfOepBnQ@mail.gmail.com>
On Fri, Oct 4, 2019 at 1:09 AM William Tu <u9012063@gmail.com> wrote:
>
> Hi Tonghao,
>
> Thanks for the patch.
>
> > On 29 Sep 2019, at 19:09, xiangxia.m.yue@gmail.com wrote:
> >
> > > From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> > >
> > > This series patch optimize openvswitch.
> > >
> > > Patch 1, 2, 4: Port Pravin B Shelar patches to
> > > linux upstream with little changes.
> > >
>
> I thought the idea of adding another cache before the flow mask
> was rejected before, due to all the potential issue of caches, ex:
> cache is exploitable, and performance still suffers when your cache
> is full. See David's slides below:
> [1] http://vger.kernel.org/~davem/columbia2012.pdf
>
> Do you have a rough number about how many flows this flow mask
> cache can handle?
Now we can cache 256 flows on a CPU, so if there are 40 CPUs, 256*10
flows will be cached.
the value of flow-mask is defined using MC_HASH_ENTRIES macro define.
We can change the value
according to different use case and CPU L1d cache.
> > > Patch 5, 6, 7: Optimize the flow looking up and
> > > simplify the flow hash.
>
> I think this is great.
> I wonder what's the performance improvement when flow mask
> cache is full?
I will test the case, I think this feature should work well with RSS
and irq affinity.
> Thanks
> William
>
> > >
> > > Patch 8: is a bugfix.
> > >
> > > The performance test is on Intel Xeon E5-2630 v4.
> > > The test topology is show as below:
> > >
> > > +-----------------------------------+
> > > | +---------------------------+ |
> > > | | eth0 ovs-switch eth1 | | Host0
> > > | +---------------------------+ |
> > > +-----------------------------------+
> > > ^ |
> > > | |
> > > | |
> > > | |
> > > | v
> > > +-----+----+ +----+-----+
> > > | netperf | Host1 | netserver| Host2
> > > +----------+ +----------+
> > >
> > > We use netperf send the 64B frame, and insert 255+ flow-mask:
> > > $ ovs-dpctl add-flow ovs-switch
> > > "in_port(1),eth(dst=00:01:00:00:00:00/ff:ff:ff:ff:ff:01),eth_type(0x0800),ipv4(frag=no)"
> > > 2
> > > ...
> > > $ ovs-dpctl add-flow ovs-switch
> > > "in_port(1),eth(dst=00:ff:00:00:00:00/ff:ff:ff:ff:ff:ff),eth_type(0x0800),ipv4(frag=no)"
> > > 2
> > > $ netperf -t UDP_STREAM -H 2.2.2.200 -l 40 -- -m 18
> > >
> > > * Without series patch, throughput 8.28Mbps
> > > * With series patch, throughput 46.05Mbps
> > >
> > > Tonghao Zhang (9):
> > > net: openvswitch: add flow-mask cache for performance
> > > net: openvswitch: convert mask list in mask array
> > > net: openvswitch: shrink the mask array if necessary
> > > net: openvswitch: optimize flow mask cache hash collision
> > > net: openvswitch: optimize flow-mask looking up
> > > net: openvswitch: simplify the flow_hash
> > > net: openvswitch: add likely in flow_lookup
> > > net: openvswitch: fix possible memleak on destroy flow table
> > > net: openvswitch: simplify the ovs_dp_cmd_new
> > >
> > > net/openvswitch/datapath.c | 63 +++++----
> > > net/openvswitch/flow.h | 1 -
> > > net/openvswitch/flow_table.c | 318
> > > +++++++++++++++++++++++++++++++++++++------
> > > net/openvswitch/flow_table.h | 19 ++-
> > > 4 files changed, 330 insertions(+), 71 deletions(-)
> > >
> > > --
> > > 1.8.3.1
> > _______________________________________________
> > dev mailing list
> > dev@openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
next prev parent reply other threads:[~2019-10-08 1:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-29 17:09 [PATCH net-next 0/9] optimize openvswitch flow looking up xiangxia.m.yue
2019-09-29 17:09 ` [PATCH net-next 1/9] net: openvswitch: add flow-mask cache for performance xiangxia.m.yue
2019-09-29 17:09 ` [PATCH net-next 2/9] net: openvswitch: convert mask list in mask array xiangxia.m.yue
2019-10-02 2:06 ` Pravin Shelar
2019-10-08 1:44 ` Tonghao Zhang
2019-09-29 17:10 ` [PATCH net-next 3/9] net: openvswitch: shrink the mask array if necessary xiangxia.m.yue
2019-09-29 17:10 ` [PATCH net-next 4/9] net: openvswitch: optimize flow mask cache hash collision xiangxia.m.yue
2019-09-29 17:10 ` [PATCH net-next 5/9] net: openvswitch: optimize flow-mask looking up xiangxia.m.yue
2019-10-02 2:06 ` Pravin Shelar
2019-10-08 3:15 ` Tonghao Zhang
2019-09-29 17:10 ` [PATCH net-next 6/9] net: openvswitch: simplify the flow_hash xiangxia.m.yue
2019-09-29 17:10 ` [PATCH net-next 7/9] net: openvswitch: add likely in flow_lookup xiangxia.m.yue
2019-10-02 2:11 ` Pravin Shelar
2019-10-08 3:21 ` Tonghao Zhang
2019-09-29 17:10 ` [PATCH net-next 8/9] net: openvswitch: fix possible memleak on destroy flow table xiangxia.m.yue
2019-09-29 17:10 ` [PATCH net-next 9/9] net: openvswitch: simplify the ovs_dp_cmd_new xiangxia.m.yue
2019-10-01 8:53 ` [PATCH net-next 0/9] optimize openvswitch flow looking up Eelco Chaudron
2019-10-03 17:08 ` [ovs-dev] " William Tu
2019-10-08 1:41 ` Tonghao Zhang [this message]
2019-10-01 21:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMDZJNX6vmouP_EDx2JMyXb6qOnXKk6XjwNDaz8mjWYVtvw7nA@mail.gmail.com \
--to=xiangxia.m.yue@gmail.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=gvrose8192@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).