netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Loic Poulain <loic.poulain@linaro.org>
To: subashab@codeaurora.org
Cc: Jakub Kicinski <kuba@kernel.org>,
	stranche@codeaurora.org,
	Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: rmnet: Adjust virtual device MTU on real device capability
Date: Tue, 8 Dec 2020 15:50:15 +0100	[thread overview]
Message-ID: <CAMZdPi9S-dgH+=q_ZP3BM6QdDkGgJR6o0ndSrRMTBAJVT7EjkQ@mail.gmail.com> (raw)
In-Reply-To: <c7be03c227efc3405f4c9cd14e52d061@codeaurora.org>

Hi Subash,

On Tue, 8 Dec 2020 at 09:19, <subashab@codeaurora.org> wrote:
>
> >> What about just returning an error on NETDEV_PRECHANGEMTU notification
> >> to prevent real device MTU change while virtual rmnet devices are
> >> linked? Not sure there is a more proper and thread safe way to manager
> >> that otherwise.
> >
> > Can't you copy what vlan devices do?  That'd seem like a reasonable and
> > well tested precedent, no?
>
> Could you try this patch. I've tried addressing most of the conditions
> here.
> I haven't seen any issues with updating the MTU when rmnet devices are
> linked.

Thanks, could you submit it as new regular patch, I'll give you my tested-by.

Regards,
Loic

      reply	other threads:[~2020-12-08 14:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-03 17:40 [PATCH] net: rmnet: Adjust virtual device MTU on real device capability Loic Poulain
2020-12-04 21:56 ` subashab
2020-12-07 16:45   ` Loic Poulain
2020-12-07 20:16     ` Jakub Kicinski
2020-12-08  8:19       ` subashab
2020-12-08 14:50         ` Loic Poulain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMZdPi9S-dgH+=q_ZP3BM6QdDkGgJR6o0ndSrRMTBAJVT7EjkQ@mail.gmail.com' \
    --to=loic.poulain@linaro.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stranche@codeaurora.org \
    --cc=subashab@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).