From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: Some suggestions for tc-tests Date: Thu, 11 Oct 2018 14:53:20 -0700 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Jamal Hadi Salim , Linux Kernel Network Developers To: Roman Mashak Return-path: Received: from mail-pl1-f173.google.com ([209.85.214.173]:34601 "EHLO mail-pl1-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726227AbeJLFWn (ORCPT ); Fri, 12 Oct 2018 01:22:43 -0400 Received: by mail-pl1-f173.google.com with SMTP id f18-v6so4873229plr.1 for ; Thu, 11 Oct 2018 14:53:32 -0700 (PDT) Sender: netdev-owner@vger.kernel.org List-ID: Hi, I tried to run tc-tests with some old iproute2 package, it is painful. I'd suggest the following improvements: 1. Create veth pair devices by its own. The most important thing for tc-tests is to automate everything, it is not friendly for users to create their own veth pair named v0p0 to just run the tests. tc-tests should be able to create a veth pair with random names and clean up them once it is finished. 2. Test iproute2 version or capability. Apparently my iproute2 doesn't support tc filter chain yet, this makes many tests failed. Ideally, each test should be able to check if the iproute2 supports the thing it wants to test, if not just skip it, at least by default. 3. Is there anything in the tests that can be done only with Python3? If we could lower the requirement to Python2, then it would be easier to setup and run these tests. Thanks!