netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Taehee Yoo <ap420073@gmail.com>
Cc: Netdev <netdev@vger.kernel.org>,
	syzbot <syzbot+aaa6fa4949cc5d9b7b25@syzkaller.appspotmail.com>,
	Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [Patch net-next 1/2] net: partially revert dynamic lockdep key changes
Date: Sat, 2 May 2020 21:24:00 -0700	[thread overview]
Message-ID: <CAM_iQpUK2r7+tO4XfRKuZ4DbAKX9j8v+ve8e36uqcftG5Vp4fw@mail.gmail.com> (raw)
In-Reply-To: <CAMArcTVei4AF7TdUEawZbJZKpf6ABAu7UwL+5iP9jVQsxqOWSQ@mail.gmail.com>

On Sat, May 2, 2020 at 12:36 AM Taehee Yoo <ap420073@gmail.com> wrote:
>
> On Fri, 1 May 2020 at 15:02, Cong Wang <xiyou.wangcong@gmail.com> wrote:
> >
>
> Hi Cong,
>
> > On Thu, Apr 30, 2020 at 12:40 AM Taehee Yoo <ap420073@gmail.com> wrote:
> > > > +static void vlan_dev_set_lockdep_one(struct net_device *dev,
> > > > +                                    struct netdev_queue *txq,
> > > > +                                    void *_subclass)
> > > > +{
> > > > +       lockdep_set_class_and_subclass(&txq->_xmit_lock,
> > > > +                                      &vlan_netdev_xmit_lock_key,
> > > > +                                      *(int *)_subclass);
> > >
> > > I think lockdep_set_class() is enough.
> > > How do you think about it?
> >
> > Good catch. I overlooked this one. Is lockdep_set_class() safe
> > for vlan stacked on vlan?
> >
>
> I think this is safe because of the LLTX flag.
> Also, I tested nested VLAN interfaces with lockdep_set_class().
> I didn't see any lockdep warning.

Great! I will update and send v2.

Thanks.

  reply	other threads:[~2020-05-03  4:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28  6:02 [Patch net-next 0/2] net: reduce dynamic lockdep keys Cong Wang
2020-04-28  6:02 ` [Patch net-next 1/2] net: partially revert dynamic lockdep key changes Cong Wang
2020-04-30  7:39   ` Taehee Yoo
2020-05-01  6:02     ` Cong Wang
2020-05-02  7:36       ` Taehee Yoo
2020-05-03  4:24         ` Cong Wang [this message]
2020-04-28  6:02 ` [Patch net-next 2/2] bonding: remove useless stats_lock_key Cong Wang
2020-04-30  6:59   ` Taehee Yoo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM_iQpUK2r7+tO4XfRKuZ4DbAKX9j8v+ve8e36uqcftG5Vp4fw@mail.gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=ap420073@gmail.com \
    --cc=dvyukov@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=syzbot+aaa6fa4949cc5d9b7b25@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).