From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FF53C43381 for ; Fri, 15 Feb 2019 18:13:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 10182218FF for ; Fri, 15 Feb 2019 18:13:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yp3Z7+hx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731655AbfBOSNK (ORCPT ); Fri, 15 Feb 2019 13:13:10 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:35323 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725835AbfBOSNJ (ORCPT ); Fri, 15 Feb 2019 13:13:09 -0500 Received: by mail-pl1-f194.google.com with SMTP id p8so5330410plo.2 for ; Fri, 15 Feb 2019 10:13:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UWSaEg321kd/IjpbsP/3iiqMU0J9wPbhE9+bbI/l/oM=; b=Yp3Z7+hxKVnMytYkPH4VlcqPNKR/6HXzRUCYOKhvp2MowKmdkSyyGEmlyD11y4F5GB 72ztJcZcAYmvOBsXeSMjvDk+JB2UWIWC4GF+rxuIpljWwTHbj3VgrgAMAR+d8T7mTY3N IiTJV3DwXV3yoICQTtnsvkSURm6u/7TRPTlY7CumoZAZWHIkSCdOo3mhs39LJsC9qIhe U9hyk3UMylib2rCAh9+cKZmD/ldWEtc7Fv5jBhGGZuPxCx4w3ZpbaDAIukqb+3phtWLt LPVpIDCdZDjT1uk9TJEQ/6+2XoIr/x7+03h6WO61jEfOndZ3zgMyOM4xqPEtvoAVCVWb h8Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UWSaEg321kd/IjpbsP/3iiqMU0J9wPbhE9+bbI/l/oM=; b=i+4mRWI2P/ueGZ8oGizurQzTXMJTwJOoOtr5xYWzpxO/2l7+FPqm2VWoPSgkO0G+Ut 52TU2Jm+NKG5xLwdXtB/bOH6aUzGbuiE0CbY+reqrIWE7OqYlMkqDddZLXNAhFKP00Tv XwzKXDdAubQS/04hnEC/8t3eRmenDmxRJ5PLK9WmJH9J+pl6WL8AKSSJRxvbiMrCuXFd tW3H8493Dmjjcj7MbKfw/A/gUZnEOiiIywjXzXMDOvsd84QKcfKXVgqQOliCKm1jd9cr FW67TKO9epp6KwYUtr/77C2pGeynS9dC44TG90bDoKntkc2uC9v69KxJzobI/114Wfbb hPEA== X-Gm-Message-State: AHQUAuYrq2MO32luTn+ins0LsE/QrbNIIAqHDKAk4IRwF6A+ZMl0SV8h Dz3gnxL1RghZ8b5vUz5k5S+MAuajNKuc/lZdKAQ= X-Google-Smtp-Source: AHgI3IZTeQoiQ7IkxZGJCmPU0NvJmU3HRPDPD8tgDGfMbdj1BuoPUrpOi5ciBWDyxSS9kQmIBxVM04Mdz0X0bUdAEQ4= X-Received: by 2002:a17:902:9893:: with SMTP id s19mr11596071plp.165.1550254389018; Fri, 15 Feb 2019 10:13:09 -0800 (PST) MIME-Version: 1.0 References: <1550242187-29660-1-git-send-email-laoar.shao@gmail.com> <1550242187-29660-6-git-send-email-laoar.shao@gmail.com> In-Reply-To: From: Cong Wang Date: Fri, 15 Feb 2019 10:12:57 -0800 Message-ID: Subject: Re: [net-next 5/5] net: sock: remove the definition of SOCK_DEBUG() To: Eric Dumazet Cc: Yafang Shao , David Miller , Daniel Borkmann , netdev , shaoyafang@didiglobal.com Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 15, 2019 at 8:26 AM Eric Dumazet wrote: > > On Fri, Feb 15, 2019 at 6:50 AM Yafang Shao wrote: > > > > As SOCK_DEBUG() isn't used any more, we can get ride of it now. > > > > No, we are still using this infrastructure from time to time. > > I told you I agreed to remove the current (obsolete) TCP call sites, > I never suggested to remove SOCK_DEBUG() completely. Since when do we upstream care about any out-of-tree users? You can always carry a patch to keep it downstream if you want, no one can stop you doing it.