Netdev Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -net-next] net: psample: depends on INET
@ 2020-05-22 19:02 Randy Dunlap
  2020-05-22 19:17 ` Cong Wang
  0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2020-05-22 19:02 UTC (permalink / raw)
  To: netdev, David Miller, LKML, linux-next, Yotam Gigi

From: Randy Dunlap <rdunlap@infradead.org>

Fix psample build error when CONFIG_INET is not set/enabled.
PSAMPLE should depend on INET instead of NET since
ip_tunnel_info_opts() is only present for CONFIG_INET.

../net/psample/psample.c: In function ‘__psample_ip_tun_to_nlattr’:
../net/psample/psample.c:216:25: error: implicit declaration of function ‘ip_tunnel_info_opts’; did you mean ‘ip_tunnel_info_opts_set’? [-Werror=implicit-function-declaration]

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Yotam Gigi <yotam.gi@gmail.com>
---
This might be too stringent...

 net/psample/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20200522.orig/net/psample/Kconfig
+++ linux-next-20200522/net/psample/Kconfig
@@ -4,7 +4,7 @@
 #
 
 menuconfig PSAMPLE
-	depends on NET
+	depends on INET
 	tristate "Packet-sampling netlink channel"
 	default n
 	help


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH -net-next] net: psample: depends on INET
  2020-05-22 19:02 [PATCH -net-next] net: psample: depends on INET Randy Dunlap
@ 2020-05-22 19:17 ` Cong Wang
  2020-05-22 19:48   ` Randy Dunlap
  0 siblings, 1 reply; 4+ messages in thread
From: Cong Wang @ 2020-05-22 19:17 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: netdev, David Miller, LKML, linux-next, Yotam Gigi

On Fri, May 22, 2020 at 12:03 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix psample build error when CONFIG_INET is not set/enabled.
> PSAMPLE should depend on INET instead of NET since
> ip_tunnel_info_opts() is only present for CONFIG_INET.
>
> ../net/psample/psample.c: In function ‘__psample_ip_tun_to_nlattr’:
> ../net/psample/psample.c:216:25: error: implicit declaration of function ‘ip_tunnel_info_opts’; did you mean ‘ip_tunnel_info_opts_set’? [-Werror=implicit-function-declaration]

Or just make this tunnel support optional. psample does not
require it to function correctly.

Thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH -net-next] net: psample: depends on INET
  2020-05-22 19:17 ` Cong Wang
@ 2020-05-22 19:48   ` Randy Dunlap
  2020-05-22 19:51     ` Cong Wang
  0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2020-05-22 19:48 UTC (permalink / raw)
  To: Cong Wang; +Cc: netdev, David Miller, LKML, linux-next, Yotam Gigi

On 5/22/20 12:17 PM, Cong Wang wrote:
> On Fri, May 22, 2020 at 12:03 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Fix psample build error when CONFIG_INET is not set/enabled.
>> PSAMPLE should depend on INET instead of NET since
>> ip_tunnel_info_opts() is only present for CONFIG_INET.
>>
>> ../net/psample/psample.c: In function ‘__psample_ip_tun_to_nlattr’:
>> ../net/psample/psample.c:216:25: error: implicit declaration of function ‘ip_tunnel_info_opts’; did you mean ‘ip_tunnel_info_opts_set’? [-Werror=implicit-function-declaration]
> 
> Or just make this tunnel support optional. psample does not
> require it to function correctly.

Sure, I thought of that, but it's not clear to me which bits of it
to make optional, so I'll leave it for its maintainer to handle.

thanks.
-- 
~Randy


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH -net-next] net: psample: depends on INET
  2020-05-22 19:48   ` Randy Dunlap
@ 2020-05-22 19:51     ` Cong Wang
  0 siblings, 0 replies; 4+ messages in thread
From: Cong Wang @ 2020-05-22 19:51 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: netdev, David Miller, LKML, linux-next, Yotam Gigi

On Fri, May 22, 2020 at 12:48 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 5/22/20 12:17 PM, Cong Wang wrote:
> > On Fri, May 22, 2020 at 12:03 PM Randy Dunlap <rdunlap@infradead.org> wrote:
> >>
> >> From: Randy Dunlap <rdunlap@infradead.org>
> >>
> >> Fix psample build error when CONFIG_INET is not set/enabled.
> >> PSAMPLE should depend on INET instead of NET since
> >> ip_tunnel_info_opts() is only present for CONFIG_INET.
> >>
> >> ../net/psample/psample.c: In function ‘__psample_ip_tun_to_nlattr’:
> >> ../net/psample/psample.c:216:25: error: implicit declaration of function ‘ip_tunnel_info_opts’; did you mean ‘ip_tunnel_info_opts_set’? [-Werror=implicit-function-declaration]
> >
> > Or just make this tunnel support optional. psample does not
> > require it to function correctly.
>
> Sure, I thought of that, but it's not clear to me which bits of it
> to make optional, so I'll leave it for its maintainer to handle.

The code commit d8bed686ab96169ac80b497d1cbed89300d97f83
adds is optional, so it can be just put into #ifdef's.

Thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-22 19:02 [PATCH -net-next] net: psample: depends on INET Randy Dunlap
2020-05-22 19:17 ` Cong Wang
2020-05-22 19:48   ` Randy Dunlap
2020-05-22 19:51     ` Cong Wang

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git