From: Cong Wang <xiyou.wangcong@gmail.com>
To: Vlad Buslov <vladbu@nvidia.com>
Cc: "Linux Kernel Network Developers" <netdev@vger.kernel.org>,
"Kumar Kartikeya Dwivedi" <memxor@gmail.com>,
"David Miller" <davem@davemloft.net>,
"Jamal Hadi Salim" <jhs@mojatatu.com>,
"Jiri Pirko" <jiri@resnulli.us>,
"Jakub Kicinski" <kuba@kernel.org>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Marcelo Ricardo Leitner" <marcelo.leitner@gmail.com>,
"Davide Caratti" <dcaratti@redhat.com>
Subject: Re: [PATCH net v2 0/3] Action initalization fixes
Date: Thu, 8 Apr 2021 15:02:09 -0700 [thread overview]
Message-ID: <CAM_iQpUmaQ2w7pd7xn4deHu6sYb8wRO62mN_97nN6Kwte7t3LQ@mail.gmail.com> (raw)
In-Reply-To: <20210407153604.1680079-1-vladbu@nvidia.com>
On Wed, Apr 7, 2021 at 8:36 AM Vlad Buslov <vladbu@nvidia.com> wrote:
>
> This series fixes reference counting of action instances and modules in
> several parts of action init code. The first patch reverts previous fix
> that didn't properly account for rollback from a failure in the middle of
> the loop in tcf_action_init() which is properly fixed by the following
> patch.
I still hate the init_res[] array, but I have no easy and better way to fix
it either, so:
Acked-by: Cong Wang <cong.wang@bytedance.com>
For the long term, we probably want to split the action ->init() into
two: ->init() and ->change(), like TC filters, which hopefully could
ease the complexity of tcf_action_init_1().
Thanks.
prev parent reply other threads:[~2021-04-08 22:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 15:36 [PATCH net v2 0/3] Action initalization fixes Vlad Buslov
2021-04-07 15:36 ` [PATCH net v2 1/3] Revert "net: sched: bump refcount for new action in ACT replace mode" Vlad Buslov
2021-04-07 15:36 ` [PATCH net v2 2/3] net: sched: fix action overwrite reference counting Vlad Buslov
2021-04-07 23:50 ` Cong Wang
2021-04-08 7:50 ` Vlad Buslov
2021-04-08 13:43 ` Jamal Hadi Salim
2021-04-08 21:52 ` Cong Wang
2021-04-08 11:59 ` Jamal Hadi Salim
2021-04-08 21:55 ` Cong Wang
2021-04-07 15:36 ` [PATCH net v2 3/3] net: sched: fix err handler in tcf_action_init() Vlad Buslov
2021-04-08 22:02 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM_iQpUmaQ2w7pd7xn4deHu6sYb8wRO62mN_97nN6Kwte7t3LQ@mail.gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
--cc=vladbu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).