From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81528C43381 for ; Fri, 15 Feb 2019 22:35:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 468E6222D9 for ; Fri, 15 Feb 2019 22:35:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mKlAyZbd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391470AbfBOWf3 (ORCPT ); Fri, 15 Feb 2019 17:35:29 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:38263 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390411AbfBOWf3 (ORCPT ); Fri, 15 Feb 2019 17:35:29 -0500 Received: by mail-pl1-f193.google.com with SMTP id e5so5629164plb.5 for ; Fri, 15 Feb 2019 14:35:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/emj39P3F5yE2+GtkU/jDqOmbIcVRIzfiZNaeFk3nEw=; b=mKlAyZbdZgl5HlQ9EuMm2i7/9c0Qtfb6w9crJ2CbR3Jx4cvVw0sermx6kvopmWksFb 02Pt3q28IwK34nhMGa01m7JiWqHjg7I35dKfxWq2Q5MbjAdWOVZxmV4fAJZVuVuwgHfq t4doDDziROUHjd3P9FJbCUAK9GdnUhZ2mBEVD21waT4GbWOs5G6eZtd6iraQIdjbifEJ vIHMzQzpK9REfR6hCgmVnBZwX/NY1cVRMth5a/WlSu0qmpPe3D2FncXSZEKNnjz2coxG QgiNttgZdI2MndulPOZKgusWxXve+JlqRKELKM4/d8hPpQ5pxjFxk8qBTfSP0x4b6hF7 idrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/emj39P3F5yE2+GtkU/jDqOmbIcVRIzfiZNaeFk3nEw=; b=qBzRX2nTvadc6xlrXEWsXqGbb53B4TOc906jENOvXJoDp/BasttPRPjVAB+v7d+uJj JZZ6Ob9wI8TmREPol3rhMYQBTiTkH9VnDTtA/d8h8w3VJvSRrpVcxNQjasRSMWaiHXyE /w/mSY5EQV+grcPUp4di1sC0jyR1tQSK50FH971DkUnFJMNEFtU+xEV4cYOMtT3P4oPk 0FFqyS7Yhwdwr/JjwmLFqAxlKAjTX6qDcYIQOUriNfzxfM3gGAD3trHNUd1OEO839Vzj sIVmNTqPRo9FSD+nEr1eYV8aHZ5VZdZmUfyf3gqc3gntV8AVA6X7RdZm1sQHaQRMVSg9 WQhg== X-Gm-Message-State: AHQUAuYc0opNRdwyF4iQyTFEaXlJGsCC+eH2mcTb7yP3ab5o+yT/cXu/ vKzMLWJWPCCLjULG6nOYzGTRJNsQ40PZyAdlcro= X-Google-Smtp-Source: AHgI3IZ1ZATkRGfP8UeLvUhfWTlTefvmzZ3zvhFgDnB4wBxCZiF+2o26Et7PD2pF5h/r1W8kkASZ8ATzZc1L0MGMf6g= X-Received: by 2002:a17:902:8641:: with SMTP id y1mr12452880plt.159.1550270128829; Fri, 15 Feb 2019 14:35:28 -0800 (PST) MIME-Version: 1.0 References: <20190211085548.7190-1-vladbu@mellanox.com> <20190211085548.7190-8-vladbu@mellanox.com> In-Reply-To: <20190211085548.7190-8-vladbu@mellanox.com> From: Cong Wang Date: Fri, 15 Feb 2019 14:35:17 -0800 Message-ID: Subject: Re: [PATCH net-next v4 07/17] net: sched: protect filter_chain list with filter_chain_lock mutex To: Vlad Buslov Cc: Linux Kernel Network Developers , Jamal Hadi Salim , Jiri Pirko , David Miller , Alexei Starovoitov , Daniel Borkmann Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 11, 2019 at 12:56 AM Vlad Buslov wrote: > +#ifdef CONFIG_PROVE_LOCKING > +static inline bool lockdep_tcf_chain_is_locked(struct tcf_chain *chain) > +{ > + return lockdep_is_held(&chain->filter_chain_lock); > +} > +#else > +static inline bool lockdep_tcf_chain_is_locked(struct tcf_block *chain) > +{ > + return true; > +} > +#endif /* #ifdef CONFIG_PROVE_LOCKING */ > + > +#define tcf_chain_dereference(p, chain) \ > + rcu_dereference_protected(p, lockdep_tcf_chain_is_locked(chain)) Are you sure you need this #ifdef CONFIG_PROVE_LOCKING? rcu_dereference_protected() should already test CONFIG_PROVE_RCU. Ditto for tcf_proto_dereference().