From: Cong Wang <xiyou.wangcong@gmail.com>
To: Taehee Yoo <ap420073@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
jwi@linux.ibm.com, kgraul@linux.ibm.com, hca@linux.ibm.com,
gor@linux.ibm.com, borntraeger@de.ibm.com,
Marek Lindner <mareklindner@neomailbox.ch>,
sw@simonwunderlich.de, a@unstable.cc, sven@narfation.org,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
dsahern@kernel.org
Subject: Re: [PATCH net-next v2 3/7] mld: add a new delayed_work, mc_delrec_work
Date: Sat, 13 Feb 2021 11:18:04 -0800 [thread overview]
Message-ID: <CAM_iQpVrD5623egpEy2BhR66smuEaTLRHgsu9YA_vrMGjacPkg@mail.gmail.com> (raw)
In-Reply-To: <20210213175148.28375-1-ap420073@gmail.com>
On Sat, Feb 13, 2021 at 9:52 AM Taehee Yoo <ap420073@gmail.com> wrote:
>
> The goal of mc_delrec_work delayed work is to call mld_clear_delrec().
> The mld_clear_delrec() is called under both data path and control path.
> So, the context of mld_clear_delrec() can be atomic.
> But this function accesses struct ifmcaddr6 and struct ip6_sf_list.
> These structures are going to be protected by RTNL.
> So, this function should be called in a sleepable context.
Hmm, but with this patch mld_clear_delrec() is called asynchronously
without waiting, is this a problem? If not, please explain why in your
changelog.
By the way, if you do not use a delay, you can just use regular work.
Thanks.
next prev parent reply other threads:[~2021-02-13 19:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-13 17:51 [PATCH net-next v2 3/7] mld: add a new delayed_work, mc_delrec_work Taehee Yoo
2021-02-13 19:18 ` Cong Wang [this message]
2021-02-14 11:30 ` Taehee Yoo
2021-02-14 14:53 ` Taehee Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM_iQpVrD5623egpEy2BhR66smuEaTLRHgsu9YA_vrMGjacPkg@mail.gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=a@unstable.cc \
--cc=ap420073@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=jwi@linux.ibm.com \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
--cc=sven@narfation.org \
--cc=sw@simonwunderlich.de \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).