From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D024AC43141 for ; Sat, 16 Nov 2019 19:47:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A606D206E1 for ; Sat, 16 Nov 2019 19:47:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O/DQ/d+S" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727529AbfKPTrq (ORCPT ); Sat, 16 Nov 2019 14:47:46 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:46967 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727473AbfKPTrp (ORCPT ); Sat, 16 Nov 2019 14:47:45 -0500 Received: by mail-pl1-f193.google.com with SMTP id l4so7059725plt.13; Sat, 16 Nov 2019 11:47:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OYC2ekx7Tzmq1QfMcXgIkodtKuvAto7LJnsdQYrM5P0=; b=O/DQ/d+SOGMDbioUU5bvadLkKDnTXUk7FRJF1g2GFbdPQm9yWrAopHx7hJg+wAtSDB aynBQ/HG50v06LEuARaPf+RM5PPAKgPRvKGVPKCnUOqFHMJGPDzXKf9+7CH1qdx+z6hE b5zIz5Y6VRUvJmjS8QbwPMYRPMVQcR7MhkbAykyzXtEMu63YVUEzjqeWMX6sqBJTZIHt JFL9dlDKuRpzk6S+rk0ztqrb8T9Vqy23SuYsik14+0KHWiS6mgbtjEvYvZJYz+Ipwmxg 4l8sV0cNGS9zko/Kg91UQV7y93HM+zE1Lrm1URK3jvL8FopPdnQzsUzMnzV5SeUzPntr nlMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OYC2ekx7Tzmq1QfMcXgIkodtKuvAto7LJnsdQYrM5P0=; b=GLbGsGWxMpJ1l9oLGcP9ABDmq9ZJv34ySeBqdG+zJi/J1qg+p15OgB0NqaLptm6XLd 8rg6qDKvxuiDobXVlSGzDLgsXXUSJDZ5vwDwgVwwtZYqrys5w2ycx9lG1H7xL95aC0c2 aHU2XpK5jwSiTKCpeoMjib99lFpM8AkmSY57JjbSuNH7q3j6ITo3247gwmbmej99siie soUkYdXBRXNBlf7b4LwI5DGBqxnKUhp1mHwqB+UAQLKHFUqp+w5IBFlPqJaSFAjeqalb Xn2qz1OuVNrcimyXVOghf87bKdtvz53W2zyLptWLkYT6gDWm6oVnGu7gyTsN6ZGelBKG ijAg== X-Gm-Message-State: APjAAAWBH6942o5uWLL4/HC/lLnQnGxq/fE8Zh1zxsMSNc1qiqtThLks 2zhbHkClMhAU8VCOiFb3WPT2BAhEhcJf+EDXEOY= X-Google-Smtp-Source: APXvYqzzKrnIp2YvOOnX+vGIyguect9QGtIIXcMScDxpXTL77ouZZoPvyilpnVU+y7dsn+efWeNlPwsQXCG9e75v9XM= X-Received: by 2002:a17:902:d684:: with SMTP id v4mr20988116ply.316.1573933664833; Sat, 16 Nov 2019 11:47:44 -0800 (PST) MIME-Version: 1.0 References: <20191112130510.91570-1-tonylu@linux.alibaba.com> <20191112130510.91570-2-tonylu@linux.alibaba.com> In-Reply-To: From: Cong Wang Date: Sat, 16 Nov 2019 11:47:33 -0800 Message-ID: Subject: Re: [PATCH v2 2/2] net: add trace events for net_device refcnt To: David Ahern Cc: Tony Lu , David Miller , Eric Dumazet , shemminger@osdl.org, Linux Kernel Network Developers , LKML Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Nov 12, 2019 at 7:27 AM David Ahern wrote: > The location alone does nothing for resolving reference count leaks; you > really have to use stack traces to pair up the hold and put and to give > context for what are repetitive locations for the hold and put. +1 And, as you are using tracepoint, you get trace filter and trigger for free, which already includes stacktrace.