From: Cong Wang <xiyou.wangcong@gmail.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH net 2/2] net_sched: Fix missing res info when create new tc_index filter
Date: Mon, 13 Aug 2018 18:46:36 -0700 [thread overview]
Message-ID: <CAM_iQpWbL=U8Wi0aJOX5-iXZggVu9rD1NcihAb0C6PwkEsmmPQ@mail.gmail.com> (raw)
In-Reply-To: <1534157044-19753-3-git-send-email-liuhangbin@gmail.com>
On Mon, Aug 13, 2018 at 3:44 AM Hangbin Liu <liuhangbin@gmail.com> wrote:
> This is because we didn't update f->result.res when create new filter. Then in
> tcindex_delete() -> tcf_unbind_filter(), we will failed to find out the res
> and unbind filter, which will trigger the WARN_ON() in cbq_destroy_class().
>
> Fix it by updating f->result.res when create new filter.
>
> Fixes: 6e0565697a106 ("net_sched: fix another crash in cls_tcindex")
> Reported-by: Li Shuang <shuali@redhat.com>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
next prev parent reply other threads:[~2018-08-14 4:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 10:44 [PATCH net 0/2] net_sched: Fix two tc_index filter init issues Hangbin Liu
2018-08-13 10:44 ` [PATCH net 1/2] net_sched: fix NULL pointer dereference when delete tcindex filter Hangbin Liu
2018-08-14 1:46 ` Cong Wang
2018-08-13 10:44 ` [PATCH net 2/2] net_sched: Fix missing res info when create new tc_index filter Hangbin Liu
2018-08-14 1:46 ` Cong Wang [this message]
2018-08-14 2:40 ` [PATCH net 0/2] net_sched: Fix two tc_index filter init issues David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM_iQpWbL=U8Wi0aJOX5-iXZggVu9rD1NcihAb0C6PwkEsmmPQ@mail.gmail.com' \
--to=xiyou.wangcong@gmail.com \
--cc=davem@davemloft.net \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).