From: Cong Wang <xiyou.wangcong@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
bpf <bpf@vger.kernel.org>, kernel-team <kernel-team@fb.com>
Subject: Re: [PATCH v2 bpf-next 1/3] bpf: Introduce bpf_timer
Date: Fri, 11 Jun 2021 00:05:27 -0700 [thread overview]
Message-ID: <CAM_iQpWh3AHNZ+J0Au7VqkJ9h4kgrLDop4asrofoCpzuBuJPkw@mail.gmail.com> (raw)
In-Reply-To: <20210611042442.65444-2-alexei.starovoitov@gmail.com>
On Thu, Jun 10, 2021 at 9:27 PM Alexei Starovoitov
<alexei.starovoitov@gmail.com> wrote:
> // Initialize the timer to call 'callback_fn' static function
> // First 4 bits of 'flags' specify clockid.
> // Only CLOCK_MONOTONIC, CLOCK_REALTIME, CLOCK_BOOTTIME are allowed.
> long bpf_timer_init(struct bpf_timer *timer, void *callback_fn, int flags);
Another unpopular point of view:
This init() is not suitable for bpf programs, because unlike kernel modules,
there is no init or exit functions for a bpf program. And timer init
is typically
called during module init.
(bpf spinlock is different, because it can be simply initialized as UNLOCKED.)
next prev parent reply other threads:[~2021-06-11 7:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 4:24 [PATCH v2 bpf-next 0/3] bpf: Introduce BPF timers Alexei Starovoitov
2021-06-11 4:24 ` [PATCH v2 bpf-next 1/3] bpf: Introduce bpf_timer Alexei Starovoitov
2021-06-11 6:42 ` Cong Wang
2021-06-11 18:45 ` Alexei Starovoitov
2021-06-15 6:10 ` Cong Wang
2021-06-16 4:53 ` Alexei Starovoitov
2021-06-11 7:05 ` Cong Wang [this message]
2021-06-11 22:12 ` Yonghong Song
2021-06-15 3:33 ` Alexei Starovoitov
2021-06-15 4:21 ` Yonghong Song
2021-06-14 16:51 ` Yonghong Song
2021-06-15 3:29 ` Alexei Starovoitov
2021-06-15 5:31 ` Andrii Nakryiko
2021-06-15 5:40 ` Alexei Starovoitov
2021-06-15 15:24 ` Andrii Nakryiko
2021-06-16 4:26 ` Alexei Starovoitov
2021-06-16 5:54 ` Andrii Nakryiko
2021-06-16 16:52 ` Alexei Starovoitov
2021-06-15 4:48 ` Andrii Nakryiko
2021-06-11 4:24 ` [PATCH v2 bpf-next 2/3] bpf: Add verifier checks for bpf_timer Alexei Starovoitov
2021-06-11 4:24 ` [PATCH v2 bpf-next 3/3] selftests/bpf: Add bpf_timer test Alexei Starovoitov
2021-06-11 6:47 ` [PATCH v2 bpf-next 0/3] bpf: Introduce BPF timers Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM_iQpWh3AHNZ+J0Au7VqkJ9h4kgrLDop4asrofoCpzuBuJPkw@mail.gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).