From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69EA2C43381 for ; Wed, 20 Feb 2019 22:36:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 371E920880 for ; Wed, 20 Feb 2019 22:36:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HrWmauig" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726848AbfBTWg6 (ORCPT ); Wed, 20 Feb 2019 17:36:58 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:45006 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726191AbfBTWg5 (ORCPT ); Wed, 20 Feb 2019 17:36:57 -0500 Received: by mail-pf1-f195.google.com with SMTP id a3so2842589pff.11 for ; Wed, 20 Feb 2019 14:36:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PI9Zl+VKSACEzh4HG5a/ugpXXiceOKJOrmjSgWSdFw0=; b=HrWmauig3rCeUSiWX9RphEkWX5Gg01FmICxjMK4LVxWYxOuiaYwArLvDE3Od9VWiHY EoknHqWRhVaI26sxD73viJBoIt5qXkhZwEG7cmcxCijLuzCkCe212GzpzkeZ+YQHIXAN j/3htiGt7ZptBuSsYEuPyhg12LnSMAdZDWOnfbI3suDI2RBZjGEHUWDUOqkMuIBO8zde JpedC233o5GlfiJQlFoLTepuSMTnNiWFLDs7F1xdbFDd7E7CaJAZ5mgSXCX24Cvlmsgd 7njv9kfOLZqZJWTVfSOMFlAc0JYsJUH8eB6I39p7uG4FT7ch/3k4+O1gFTZ/FN+9ZM0i kQQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PI9Zl+VKSACEzh4HG5a/ugpXXiceOKJOrmjSgWSdFw0=; b=MLlQR/nMx9L2gGS8P3kq7cUyU2W5Fs2AJ0o+6ryBbNbJmoXH5hMcWESx+yCC7BhvGl TBR7LPdVDtZgmr/AyQknJHlfUsfEvU5YUFGAtzk9RRO1n1PmPtSp+mdSxdrC/HMMM/Nr m7+U7p/0hW4IxGjY03CD86EDRW29gzvI2vmWnIpPQcLnbQa8ydGNX0unRJ2+Dvxb/NLr kyEbAkIyJFm0HFj0Jh9No7/Md3Mz8LdgRNSf3hXC+QzzWumt2/xWbMAaHvOHv1ljaZ61 0COu2zv7oQr6Vxl/+7RFA/M/IL2wZ5e34mt/8/utEZfk8kpczb+WJx1tBXLmdJOkp2Ww 2g2g== X-Gm-Message-State: AHQUAuY7amUVTpAAEMCN0QeDZU570PPxVzAmrNiXBktn6cLRISDIYsuI qE1bjHtsULGB+aEDu4jeRBhXEFw4BYtVZLDzeW3sLw== X-Google-Smtp-Source: AHgI3IaydOE3rFTDEn2qGrqkGyMBu2MuvsBdCWlFqri68hsnrb54OAcSJJ8g3kdUoJF84sKrnRr52OVq1Fhq7cbBots= X-Received: by 2002:a65:4381:: with SMTP id m1mr30830672pgp.358.1550702217298; Wed, 20 Feb 2019 14:36:57 -0800 (PST) MIME-Version: 1.0 References: <20190214074712.17846-1-vladbu@mellanox.com> <20190214074712.17846-13-vladbu@mellanox.com> In-Reply-To: From: Cong Wang Date: Wed, 20 Feb 2019 14:36:45 -0800 Message-ID: Subject: Re: [PATCH net-next 12/12] net: sched: flower: set unlocked flag for flower proto ops To: Vlad Buslov Cc: Linux Kernel Network Developers , Jamal Hadi Salim , Jiri Pirko , David Miller Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 19, 2019 at 2:15 AM Vlad Buslov wrote: > > > On Mon 18 Feb 2019 at 19:27, Cong Wang wrote: > > On Wed, Feb 13, 2019 at 11:47 PM Vlad Buslov wrote: > >> > >> Set TCF_PROTO_OPS_DOIT_UNLOCKED for flower classifier to indicate that its > >> ops callbacks don't require caller to hold rtnl lock. > > > > So, if this means RTNL is gone for all cls_flower changes, why > > do I still see rtnl_lock() in cls_flower.c after all your patches in > > this set? > > It doesn't say that rtnl lock is gone, what it says is that caller > doesn't have to obtain rtnl lock before calling flower ops callbacks. So RTNL lock is still a bottle neck after all of these patches, isn't it? :) Yeah, please kindly add an explanation for why RTNL lock is still here. Thanks.