From: Cong Wang <xiyou.wangcong@gmail.com>
To: Lucas Bates <lucasb@mojatatu.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
Chris Mi <chrism@mellanox.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Jiri Pirko <jiri@resnulli.us>,
John Fastabend <john.fastabend@gmail.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: [Patch net 00/16] net_sched: fix races with RCU callbacks
Date: Wed, 1 Nov 2017 09:59:04 -0700 [thread overview]
Message-ID: <CAM_iQpXaZTFoQj349d2aookUteFFJFFUH82o9P8n2N_pRjPMdQ@mail.gmail.com> (raw)
In-Reply-To: <CAMDBHYLdQHXzbEiZdh+Y_NeY8ipE1zE4HHZ9NhN24G7v5PFE4w@mail.gmail.com>
On Wed, Nov 1, 2017 at 9:55 AM, Lucas Bates <lucasb@mojatatu.com> wrote:
> On Tue, Oct 31, 2017 at 7:02 PM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
>> On Tue, Oct 31, 2017 at 3:09 PM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
>>>
>>> This almost rules out the guilty of this patchset.
>>>
>>> I will provide a patch for you to test, since I can't reproduce it here.
>>>
>>
>> Lucas, please test the attached patch, it applies to latest -net.
>>
>> Note, it is a combination of 3 patches which together close the
>> use-after-free you reported here, I hope.
>>
>> Please let me know if this works. My basic tests run well without
>> any stack traces or memory leaks.
>
> The results look good to me.
>
> I compiled with the patch and ran the test again in a loop. I set it
> to run 50 times in a row and didn't trigger the bug once (previous
> record was 4 times).
Thanks a lot! I will add your Reported-by and Tested-by and send
out the patches.
prev parent reply other threads:[~2017-11-01 16:59 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 1:24 [Patch net 00/16] net_sched: fix races with RCU callbacks Cong Wang
2017-10-27 1:24 ` [Patch net 01/16] net_sched: introduce a workqueue for RCU callbacks of tc filter Cong Wang
2017-10-27 4:05 ` Eric Dumazet
2017-10-27 4:28 ` Cong Wang
2017-10-27 4:39 ` Eric Dumazet
2017-10-27 11:55 ` Paul E. McKenney
2017-10-27 15:43 ` Cong Wang
2017-10-27 15:37 ` Cong Wang
2017-10-27 15:52 ` Eric Dumazet
2017-10-27 1:24 ` [Patch net 02/16] net_sched: use tcf_queue_work() in basic filter Cong Wang
2017-10-27 1:24 ` [Patch net 03/16] net_sched: use tcf_queue_work() in bpf filter Cong Wang
2017-10-27 1:24 ` [Patch net 04/16] net_sched: use tcf_queue_work() in cgroup filter Cong Wang
2017-10-27 1:24 ` [Patch net 05/16] net_sched: use tcf_queue_work() in flow filter Cong Wang
2017-10-27 1:24 ` [Patch net 06/16] net_sched: use tcf_queue_work() in flower filter Cong Wang
2017-10-27 1:24 ` [Patch net 07/16] net_sched: use tcf_queue_work() in fw filter Cong Wang
2017-10-27 1:24 ` [Patch net 08/16] net_sched: use tcf_queue_work() in matchall filter Cong Wang
2017-10-27 1:24 ` [Patch net 09/16] net_sched: use tcf_queue_work() in u32 filter Cong Wang
2017-10-27 1:24 ` [Patch net 10/16] net_sched: use tcf_queue_work() in route filter Cong Wang
2017-10-27 1:24 ` [Patch net 11/16] net_sched: use tcf_queue_work() in rsvp filter Cong Wang
2017-10-27 1:24 ` [Patch net 12/16] net_sched: use tcf_queue_work() in tcindex filter Cong Wang
2017-10-27 1:24 ` [Patch net 13/16] net_sched: add rtnl assertion to tcf_exts_destroy() Cong Wang
2017-10-27 1:24 ` [Patch net 14/16] net_sched: fix call_rcu() race on act_sample module removal Cong Wang
2017-10-27 1:24 ` [Patch net 15/16] selftests: Introduce a new script to generate tc batch file Cong Wang
2017-10-27 1:24 ` [Patch net 16/16] selftests: Introduce a new test case to tc testsuite Cong Wang
2017-10-29 14:41 ` [Patch net 00/16] net_sched: fix races with RCU callbacks David Miller
2017-10-30 22:39 ` Lucas Bates
2017-10-30 23:12 ` Cong Wang
2017-10-31 1:46 ` Lucas Bates
[not found] ` <CAMDBHYJTMv4MDQENNKjOXaUBHyXicOnkM_j+i7__3d1CAgdVRg@mail.gmail.com>
2017-10-31 5:44 ` Cong Wang
2017-10-31 11:00 ` Jamal Hadi Salim
2017-10-31 18:55 ` Lucas Bates
2017-10-31 19:13 ` Lucas Bates
2017-10-31 22:09 ` Cong Wang
2017-10-31 23:02 ` Cong Wang
2017-11-01 16:55 ` Lucas Bates
2017-11-01 16:59 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM_iQpXaZTFoQj349d2aookUteFFJFFUH82o9P8n2N_pRjPMdQ@mail.gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=chrism@mellanox.com \
--cc=daniel@iogearbox.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=lucasb@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).