netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: "Samudrala, Sridhar" <sridhar.samudrala@intel.com>
Cc: Alexander Duyck <alexander.duyck@gmail.com>,
	Eric Dumazet <edumazet@google.com>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: Three questions about busy poll
Date: Fri, 15 Feb 2019 11:18:29 -0800	[thread overview]
Message-ID: <CAM_iQpXa_ra5Gi3Wiv+JRwixArozLDKOHHAdBym_3k1CzPYuaw@mail.gmail.com> (raw)
In-Reply-To: <bfaff1c6-1269-1c33-31e1-0a78f78d7214@intel.com>

On Thu, Feb 14, 2019 at 4:43 PM Samudrala, Sridhar
<sridhar.samudrala@intel.com> wrote:
>
>
> On 2/14/2019 12:15 PM, Cong Wang wrote:
>
> Hello,
>
> While looking into the busy polling in Linux kernel, three questions
> come into my mind:
>
> 1. In the document[1], it claims sysctl.net.busy_poll depends on
> either SO_BUSY_POLL or sysctl.net.busy_read. However, from the code in
> ep_set_busy_poll_napi_id(), I don't see such a dependency. It simply
> checks sysctl_net_busy_poll and sk->sk_napi_id, but sk->sk_napi_id is
> always set as long as we enable CONFIG_NET_RX_BUSY_POLL. So what I am
> missing here?
>
> epoll based busypoll is only based on global sysctl_net_busy_poll.
> busy_poll value is used with poll()/select()/epoll and and busy_read is used
> with socket recvmsg

Right, I was confused by what the term "poll" refers to.


>
> 2. Why there is no socket option for sysctl.net.busy_poll? Clearly
> sysctl_net_busy_poll is global and SO_BUSY_POLL only works for
> sysctl.net.busy_read.
>
>
> Not sure if it is useful to make it a per socket option. I think it could
> be a per poll/epoll fd option


It is useful, however, from Willem's reply it looks like hard to push it
down from epoll() interface to each socket.

>
> 3. How is SO_INCOMING_NAPI_ID supposed to be used? I can't find any
> useful documents online. Any example or more detailed doc?
>
>
> A app can create one worker thread per device queue and a worker thread
> for an incoming connection can be selected based on SO_INCOMING_NAPI_ID so that
> all connections coming on a queue are processed by the same thread. This will
> allow epoll from a thread to be associated with sockets that receive packets
> from a single queue allowing busy polling.
>

This information is very useful. It also requires each thread pinning to each
CPU/RX queue, right?

Anyway, I will add this information to socket.7 man page.

Thanks!

  parent reply	other threads:[~2019-02-15 19:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-14 20:15 Cong Wang
2019-02-15  0:39 ` Willem de Bruijn
2019-02-15 19:04   ` Cong Wang
2019-02-15 22:46     ` Willem de Bruijn
2019-02-19  4:30       ` Cong Wang
2019-02-19 17:04         ` Willem de Bruijn
     [not found] ` <bfaff1c6-1269-1c33-31e1-0a78f78d7214@intel.com>
2019-02-15 19:18   ` Cong Wang [this message]
2019-02-22 20:00     ` Samudrala, Sridhar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM_iQpXa_ra5Gi3Wiv+JRwixArozLDKOHHAdBym_3k1CzPYuaw@mail.gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=alexander.duyck@gmail.com \
    --cc=edumazet@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=sridhar.samudrala@intel.com \
    --subject='Re: Three questions about busy poll' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).