From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE830C4363D for ; Thu, 8 Oct 2020 01:42:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 541592145D for ; Thu, 8 Oct 2020 01:42:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hyNUg4AN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728077AbgJHBmv (ORCPT ); Wed, 7 Oct 2020 21:42:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727977AbgJHBmu (ORCPT ); Wed, 7 Oct 2020 21:42:50 -0400 Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E33AC061755 for ; Wed, 7 Oct 2020 18:42:49 -0700 (PDT) Received: by mail-il1-x143.google.com with SMTP id b2so4240600ilr.1 for ; Wed, 07 Oct 2020 18:42:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=83ySpvqV5gFUnQZcQCmMD2CO2gRY14MfiLuSTGuy8c0=; b=hyNUg4ANCZFve+TC/Sy0327FUcDTPl9OWfXbaBmH/DauMQgAWLko4QL1Rqi96KW2yx PS/od/lVL4HHnG8KM4hVAV3lOfLGMFG9+UdYBI19JaGIV++vQ+vLR979Rv6IyNcyh8Cy gUXwDxAxw+YpMNY4JXjodBaKm6VepdcJluGxuTHb1jF8xH9pF7tYALVFlbHjLfAF3+n5 RNLSrzJn1RUov7FAgfXlzmaWMS9pUerNG6/mgOpg/CPXG0Irh2SnPHpLafdZuWVXQ0jI ecatTjPeptKUdF63HEMX7XuhBindxfbOQ6MqGApkse+Nr+DRbZyNg83CQybX6kzU7LT9 5+uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=83ySpvqV5gFUnQZcQCmMD2CO2gRY14MfiLuSTGuy8c0=; b=NzC9g75ZtrlmkXfrgdLZhTkjBtB5h2FIqHgFohIkW3UTuxNNIpRSfDbnlCl3HU+TQm cu+zWh7oPDSYTY8yb/Z2Zc7vKvLTMHfTDi93GXJpaw24YozWj0Sh9F3KUUErHln6t7EO b8+HMb+WC2IuMdSHovcs4QazffDpc28pyeNmWSuUSuX93J6pVhddPhapl3p2jFP/XD/N ciQOTV9IxXvwxjHgrM/s7qnXhCqnWEuVSjPXljRjbKhym3+HY9n4OmWiR80HJ5d7hYY3 wG++vMRSG4Z5vbGjpyyM8lYJZfnQp6PLW6/9b11PT858pMhik/zeleQIu8yLABXR4919 OXHw== X-Gm-Message-State: AOAM530gAQEaPtFNiinr69hExZ5ejIFmQ5GBHW1974BP13o3Zh4I8tkp dWayamzN3iaBklFjTY29uxwJv3S0o21JyaqAeqA= X-Google-Smtp-Source: ABdhPJwm6eXpFhdRlmN+QVPcuCNn2oVFfnHGwXvA2yHiCjWRajkQPra9yU5RwgsQYo4CqYmAjqRCFbS9lR3YLCUEeRs= X-Received: by 2002:a92:7751:: with SMTP id s78mr2383792ilc.144.1602121368439; Wed, 07 Oct 2020 18:42:48 -0700 (PDT) MIME-Version: 1.0 References: <20201007165111.172419-1-eric.dumazet@gmail.com> In-Reply-To: <20201007165111.172419-1-eric.dumazet@gmail.com> From: Cong Wang Date: Wed, 7 Oct 2020 18:42:37 -0700 Message-ID: Subject: Re: [PATCH net-next] net/sched: get rid of qdisc->padded To: Eric Dumazet Cc: "David S . Miller" , netdev , Eric Dumazet , Allen Pais Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Oct 7, 2020 at 9:51 AM Eric Dumazet wrote: > > From: Eric Dumazet > > kmalloc() of sufficiently big portion of memory is cache-aligned > in regular conditions. If some debugging options are used, > there is no reason qdisc structures would need 64-byte alignment > if most other kernel structures are not aligned. > > This get rid of QDISC_ALIGN and QDISC_ALIGNTO. > > Addition of privdata field will help implementing > the reverse of qdisc_priv() and documents where > the private data is. > > Signed-off-by: Eric Dumazet > Cc: Cong Wang > Cc: Allen Pais Acked-by: Cong Wang Thanks.