From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: "Arınç ÜNAL" <arinc.unal@arinc9.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
DENG Qingfang <dqfext@gmail.com>,
erkin.bozoglu@xeront.com, netdev <netdev@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"open list:MIPS" <linux-mips@vger.kernel.org>
Subject: Re: [PATCH 04/10] dt-bindings: memory: mt7621: add syscon as compatible string
Date: Thu, 15 Sep 2022 05:21:21 +0200 [thread overview]
Message-ID: <CAMhs-H-0XV9ocrG3_MuVc3Q=o8HnYso2CqUURjVR3OMc=dAMYg@mail.gmail.com> (raw)
In-Reply-To: <44045164-692d-c8f5-3216-b043fb821634@arinc9.com>
On Wed, Sep 14, 2022 at 5:19 PM Arınç ÜNAL <arinc.unal@arinc9.com> wrote:
>
> On 14.09.2022 18:14, Rob Herring wrote:
> > On Wed, Sep 14, 2022 at 11:54:45AM +0300, Arınç ÜNAL wrote:
> >> Add syscon as a constant string on the compatible property as it's required
> >> for the SoC to work. Update the example accordingly.
> >
> > It's not required. It's required to automagically create a regmap. That
> > can be done yourself as well. The downside to adding 'syscon' is it
> > requires a DT update. Maybe that's fine for this platform? I don't know.
>
> My GB-PC2 won't boot without syscon on mt7621.dtsi. This string was
> always there on the memory controller node on mt7621.dtsi.
The string was introduced because the mt7621 clock driver needs to
read some registers creating a regmap from the syscon. The bindings
were added before the clock driver was properly mainlined and at first
the clock driver was using ralink architecture dependent operations
rt_memc_* defined in
'arch/mips/include/asm/mach-ralink/ralink_regs.h'. I forgot to update
the mem controller binding when memc became a syscon so I think this
patch is correct. I also think the sample should use 'syscon' in the
node name instead of memory-controller.
Best regards,
Sergio Paracuellos
>
> Arınç
next prev parent reply other threads:[~2022-09-15 3:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 8:54 [PATCH net-next 00/10] dt-bindings and mt7621 devicetree changes Arınç ÜNAL
2022-09-14 8:54 ` [PATCH 01/10] dt-bindings: net: drop old mediatek bindings Arınç ÜNAL
2022-09-14 15:06 ` Rob Herring
2022-09-14 8:54 ` [PATCH 02/10] dt-bindings: net: dsa: mediatek,mt7530: change mt7530 switch address Arınç ÜNAL
2022-09-14 15:07 ` Rob Herring
2022-09-14 8:54 ` [PATCH 03/10] dt-bindings: net: dsa: mediatek,mt7530: expand gpio-controller description Arınç ÜNAL
2022-09-14 15:08 ` Rob Herring
2022-09-14 8:54 ` [PATCH 04/10] dt-bindings: memory: mt7621: add syscon as compatible string Arınç ÜNAL
2022-09-14 9:03 ` Sergio Paracuellos
2022-09-14 15:14 ` Rob Herring
2022-09-14 15:18 ` Arınç ÜNAL
2022-09-15 3:21 ` Sergio Paracuellos [this message]
2022-09-15 6:24 ` Arınç ÜNAL
2022-09-14 8:54 ` [PATCH 05/10] mips: dts: ralink: mt7621: fix some dtc warnings Arınç ÜNAL
2022-09-14 9:14 ` Sergio Paracuellos
2022-09-14 10:45 ` Arınç ÜNAL
2022-09-15 3:30 ` Sergio Paracuellos
2022-09-15 5:59 ` Sergio Paracuellos
2022-09-15 6:24 ` Arınç ÜNAL
2022-09-14 8:54 ` [PATCH 06/10] mips: dts: ralink: mt7621: remove interrupt-parent from switch node Arınç ÜNAL
2022-09-14 9:15 ` Sergio Paracuellos
2022-09-14 8:54 ` [PATCH 07/10] mips: dts: ralink: mt7621: change phy-mode of gmac1 to rgmii Arınç ÜNAL
2022-09-14 9:17 ` Sergio Paracuellos
2022-09-14 8:54 ` [PATCH 08/10] mips: dts: ralink: mt7621: change mt7530 switch address Arınç ÜNAL
2022-09-15 5:09 ` Sergio Paracuellos
2022-09-14 8:54 ` [PATCH 09/10] mips: dts: ralink: mt7621: fix external phy on GB-PC2 Arınç ÜNAL
2022-09-15 5:09 ` Sergio Paracuellos
2022-09-14 8:54 ` [PATCH 10/10] mips: dts: ralink: mt7621: add GB-PC2 LEDs Arınç ÜNAL
2022-09-15 5:08 ` Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMhs-H-0XV9ocrG3_MuVc3Q=o8HnYso2CqUURjVR3OMc=dAMYg@mail.gmail.com' \
--to=sergio.paracuellos@gmail.com \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=arinc.unal@arinc9.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=erkin.bozoglu@xeront.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=tsbogend@alpha.franken.de \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).