netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ardb@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	"open list:BPF JIT for MIPS (32-BIT AND 64-BIT)" 
	<netdev@vger.kernel.org>, Jassi Brar <jaswinder.singh@linaro.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Willy Liu <willy.liu@realtek.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Masahisa Kojima <masahisa.kojima@linaro.org>,
	Serge Semin <fancer.lancer@gmail.com>
Subject: Re: [PATCH net] netsec: ignore 'phy-mode' device property on ACPI systems
Date: Tue, 20 Oct 2020 15:23:31 +0200	[thread overview]
Message-ID: <CAMj1kXEEBe4Se1jy07B=5gnfGxty=cPM_5fJ2+5A-dZ6BX3uHw@mail.gmail.com> (raw)
In-Reply-To: <20201020124937.GW456889@lunn.ch>

On Tue, 20 Oct 2020 at 14:49, Andrew Lunn <andrew@lunn.ch> wrote:
>
> > I hope Andrew is fine with the current changes
>
> Yes, i'm O.K. with it.

Thanks

> Making phy-mode optional would just make the
> driver more uniform with others.
>


Making phy-mode optional is fine with me, but I think it would belong
in a separate patch in any case. But I'd still prefer having the
possibility to spot bogus phy-mode values rather than ignoring them.

  reply	other threads:[~2020-10-20 13:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-18 16:36 [PATCH net] netsec: ignore 'phy-mode' device property on ACPI systems Ard Biesheuvel
2020-10-18 17:52 ` Andrew Lunn
2020-10-18 20:32   ` Ilias Apalodimas
2020-10-19  6:30     ` Ard Biesheuvel
2020-10-20  8:47       ` Ilias Apalodimas
2020-10-20 12:49         ` Andrew Lunn
2020-10-20 13:23           ` Ard Biesheuvel [this message]
2020-10-20 12:50 ` Andrew Lunn
2020-10-20 23:12   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMj1kXEEBe4Se1jy07B=5gnfGxty=cPM_5fJ2+5A-dZ6BX3uHw@mail.gmail.com' \
    --to=ardb@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=fancer.lancer@gmail.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jaswinder.singh@linaro.org \
    --cc=kuba@kernel.org \
    --cc=masahisa.kojima@linaro.org \
    --cc=mhiramat@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=willy.liu@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).