From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 566AAC4320A for ; Mon, 16 Aug 2021 19:23:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3CC3C60EFE for ; Mon, 16 Aug 2021 19:23:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230325AbhHPTXj (ORCPT ); Mon, 16 Aug 2021 15:23:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229758AbhHPTXi (ORCPT ); Mon, 16 Aug 2021 15:23:38 -0400 Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B75BFC0613C1 for ; Mon, 16 Aug 2021 12:23:06 -0700 (PDT) Received: by mail-yb1-xb2c.google.com with SMTP id r4so12005249ybp.4 for ; Mon, 16 Aug 2021 12:23:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vFPwTBww7HCfgcrya8tDZnP7/RkqO96aoh1ArMM5DY4=; b=vZ6ODT6K51FYe7v5j1ZJgTBaKdzBTUpxqFN4KAFDzaFqZcJzKDfjAT3i2rMh2HGSgJ iv06p1rxGJElyiNNUKJjZQcS4YSPt65aq4BuuoFJ8wFOXX76OyPKDK4dllYXKjiHIK2t uTnY+/frCK20rCUslEWC5xUe3cxqCCZSeJc/Z9P25kURFA2crXd9KJCjPq5HbChAKmp7 gx8eBw6qmNkXBeUwFdXacMIVsvsX136dGL5jOIRWMQmH2jwym2xoxLhDtRgP+TcTyiep wlIwPqibVKE3eLWmauWhtEp7xORuNwrDFrVf6Y3rExuTKMTR/3u05+gGvF6lvk39jca2 3/nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vFPwTBww7HCfgcrya8tDZnP7/RkqO96aoh1ArMM5DY4=; b=Q92NIXXPbivMxagZbQOHWWFrZIO/Wx29JemCb4YguCVpukXAPu4mmjkQPeC3hgbj8H FYWSyJXCDakBsZqAELsOHo1giyPYPYtl67tKfDkRAOcGa4Rs/GFv1fAeXUpiM8qjbka1 CofwqWoSCvU5w4D0Dma42CpbFG91Dawbm/7Ff5+inGuqIPloEc+qMunUzmQ3HR4Ipnsh xfsfIlNo5jUw+/kpidSeNfT6ud0tMYe9jWepfJ29rsn4Q9C2cJjXuZh2Uw9Q8nEewaMU KGXF66gfqzuN0/9tfhyrcD4eCOY1J5VzuOI9zlWBm7KVQ1VCJ7bzRKAvbE5rdx5XfXtK FCYg== X-Gm-Message-State: AOAM53142k3unB5lD7EuCFGDVm47vdHOd/2jDSQiiuxDch90LzC3bOQU zCAQlS/1OgXL2M7H6hmf9LIyiRUZvCmMgkcZGFgiDw== X-Google-Smtp-Source: ABdhPJxwXZrFe4LWrpZFpwgg7gLZvKHb3ZIrP9S0LtYkOZmaPsEtio72uZa7F9r34JcVRyMCEwKaL7zFY0sq8jjEgQs= X-Received: by 2002:a25:505:: with SMTP id 5mr23079960ybf.157.1629141786081; Mon, 16 Aug 2021 12:23:06 -0700 (PDT) MIME-Version: 1.0 References: <20210816115953.72533-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20210816115953.72533-1-andriy.shevchenko@linux.intel.com> From: Bartosz Golaszewski Date: Mon, 16 Aug 2021 21:22:55 +0200 Message-ID: Subject: Re: [PATCH v1 0/6] gpio: mlxbf2: Introduce proper interrupt handling To: Andy Shevchenko Cc: David Thompson , LKML , linux-gpio , netdev , ACPI Devel Maling List , Linus Walleij , "David S. Miller" , Jakub Kicinski , "Rafael J. Wysocki" , Asmaa Mnebhi , Liming Sun Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Aug 16, 2021 at 2:00 PM Andy Shevchenko wrote: > > This is just a WIP / TODO series based on the discussion [1]. > I hope nVidia will finish it and fix the initial problem sooner than later. > > Bart, Linus, First 4 patches may be directly applied to the tree (they are > at least compile-tested, but I believe they won't change any functionality. > > Patch 5 is some stubs that should have been done in the driver. > Patch 6 is follow up removal of custom GPIO IRQ handling from > Mellanox GBE driver. Both of them are quite far from finishing, > but it's a start for nVidia to develop and test proper solution. > > In any case, I will probably sent end this week the ACPI IRQ abuse > part from the GBE driver (I won't touch OF path). > > ARs for nVidia: > 0) review this series; > 1) properly develop GPIO driver; > 2) replace custom code with correct one; > 3) send the work for review to GPIO and ACPI maintainers (basically list > of this series). > > On my side I will help you if you have any questions regarding to GPIO > and ACPI. > > Andy Shevchenko (6): > gpio: mlxbf2: Convert to device PM ops > gpio: mlxbf2: Drop wrong use of ACPI_PTR() > gpio: mlxbf2: Use devm_platform_ioremap_resource() > gpio: mlxbf2: Use DEFINE_RES_MEM_NAMED() helper macro > TODO: gpio: mlxbf2: Introduce IRQ support > TODO: net: mellanox: mlxbf_gige: Replace non-standard interrupt > handling > > drivers/gpio/gpio-mlxbf2.c | 151 ++++++++++--- > .../mellanox/mlxbf_gige/mlxbf_gige_gpio.c | 212 ------------------ > 2 files changed, 120 insertions(+), 243 deletions(-) > delete mode 100644 drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_gpio.c > > -- > 2.30.2 > Applied first four patches. Bart