From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5A65C4363D for ; Fri, 25 Sep 2020 08:15:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4144C207C4 for ; Fri, 25 Sep 2020 08:15:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="cxESfqXp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727674AbgIYIPN (ORCPT ); Fri, 25 Sep 2020 04:15:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727489AbgIYIPM (ORCPT ); Fri, 25 Sep 2020 04:15:12 -0400 Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1C55C0613D3 for ; Fri, 25 Sep 2020 01:15:11 -0700 (PDT) Received: by mail-ej1-x642.google.com with SMTP id p15so1860318ejm.7 for ; Fri, 25 Sep 2020 01:15:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ji8pw3pg6KNs2Rx3h2YvAgjNZSLkG03JCK86FrD3E1w=; b=cxESfqXpHGzBbP1O6bDBtq8knQK0st1mJYZ82Z1fQ7Z00dyyZAG504QmT5zi7IQ/Js ckhJMCGg1J9JkNFe2xy8jYWOBC2i/czhNkUh6nrdeTFam1o2WdHWbqIZCHgSw+xDYRjv BqWEsLQn5xWR5JiJlJJazOEr6POkk2R+2h1uY5pOxxbmDkMDKsHJ0wl1T++pXQ9+dC5O hwq/nGbEeCFxrFTkBngvofwhnBAszOf4B+H9iYLVnlKc7JeBIrT5KICPXPR9GWxVV7wf j1kXWnEUQhfMjt4cSpljLnbRRhHWPsYgwwTOrQbpwgFQwS2rT1Opp8dqGiTSQODX/O+C L/Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ji8pw3pg6KNs2Rx3h2YvAgjNZSLkG03JCK86FrD3E1w=; b=O30lQ/oaU6/yBeoKd4PIwncobUtqFrHIceO6wJRRYa6eHiqFRNx8eTC259M3X5YREL LH0/CD0TxiW1rXf9aYMWVwVSMGwQQfuhPlOzOJPoE/NgAxtHdcB1mAU+L1ANa8yE4E+b lDuPqIJyfXYIXxxobWyQ5CY7y9PDMxHxJXFXiJ2zsRrFSOkalQ7POafyXcStuuER0Urt AsBIZCBPfH+ZTzPRBwX8NPEFgj1wvg9U7W2KzFBqaf0yBv86HwsEbtNLuVZRxqh1JcXj Cu971NXH/SkJAzORveFId4SrHU51165s4uegXSzAVnlgO1mLN6kK/mVZCCwRv0btJyTl G9TQ== X-Gm-Message-State: AOAM5323BU0hT/hI5k1ck1v2sNZjkVytCPFhU2lARe1xGTik+G+Otl52 vt2f/rmtSP8BYUY8yGJwvfYl3KAYR//w6NBXc9GO8A== X-Google-Smtp-Source: ABdhPJymdkfGH2R7Mg5iggu7WJvmZaEuEMqPDXhraYi9HYtU1cBau2PuTx7QDCG/djZ1MahcHaeB1AX/Xrt04rP/YXg= X-Received: by 2002:a17:906:7f15:: with SMTP id d21mr1605118ejr.470.1601021710519; Fri, 25 Sep 2020 01:15:10 -0700 (PDT) MIME-Version: 1.0 References: <20200925024247.993-1-yongxin.liu@windriver.com> In-Reply-To: <20200925024247.993-1-yongxin.liu@windriver.com> From: Bartosz Golaszewski Date: Fri, 25 Sep 2020 10:14:59 +0200 Message-ID: Subject: Re: [PATCH] Revert "net: ethernet: ixgbe: check the return value of ixgbe_mii_bus_init()" To: Yongxin Liu Cc: "David S . Miller" , netdev , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Sep 25, 2020 at 4:45 AM Yongxin Liu wrote: > > This reverts commit 09ef193fef7efb0175a04634853862d717adbb95. > > For C3000 family of SoCs, they have four ixgbe devices sharing a single MDIO bus. > ixgbe_mii_bus_init() returns -ENODEV for other three devices. The propagation > of the error code makes other three ixgbe devices unregistered. > > Signed-off-by: Yongxin Liu > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > index 2f8a4cfc5fa1..5e5223becf86 100644 > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > @@ -11031,14 +11031,10 @@ static int ixgbe_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > IXGBE_LINK_SPEED_10GB_FULL | IXGBE_LINK_SPEED_1GB_FULL, > true); > > - err = ixgbe_mii_bus_init(hw); > - if (err) > - goto err_netdev; > + ixgbe_mii_bus_init(hw); > > return 0; > > -err_netdev: > - unregister_netdev(netdev); > err_register: > ixgbe_release_hw_control(adapter); > ixgbe_clear_interrupt_scheme(adapter); > -- > 2.14.4 > Then we should check if err == -ENODEV, not outright ignore all potential errors, right? Bartosz